A structural change for aliased plugin declarations to support alias doc headers.#13971
Merged
mashhurs merged 3 commits intoelastic:mainfrom Apr 14, 2022
mashhurs:alias-registry-structure-change
Merged
A structural change for aliased plugin declarations to support alias doc headers.#13971mashhurs merged 3 commits intoelastic:mainfrom mashhurs:alias-registry-structure-change
mashhurs merged 3 commits intoelastic:mainfrom
mashhurs:alias-registry-structure-change
Conversation
This was referenced Apr 3, 2022
andsel
requested changes
Apr 12, 2022
Contributor
andsel
left a comment
There was a problem hiding this comment.
The general idea is good, left a request to move AliasPlugin to be immutable and expose the required behavior instead of data.
logstash-core/src/main/java/org/logstash/plugins/aliases/AliasPlugin.java
Show resolved
Hide resolved
logstash-core/src/main/java/org/logstash/plugins/aliases/AliasPlugin.java
Outdated
Show resolved
Hide resolved
andsel
approved these changes
Apr 13, 2022
Contributor
andsel
left a comment
There was a problem hiding this comment.
LGTM
@mashhurs nice re-shaping of the YAML structure and also the introduction of AliasDocumentReplace class.
Left a comment to check if we can put some logic into the pojos at the end they are domain classes that provides also some context.
…Unit tests failure fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
A structural change of aliased plugins declaration to support alias doc headers to replace.
What does this PR do?
When plugin reference doc generator workflow runs it generates a document for artifact plugin but not for aliased plugins. Aliased plugin docs are copy of artifact plugins with different doc headers. This PR helps to define the doc header where doc generator can use to generate the doc for alised plugins.
replacesfield especially is helpful to create a aliased plugin doc header by replacing artifact doc entries.Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
User logger to log the
extractDefinitions() -> aliasedPlugins & defaultDefinitions vars: