Skip to content

Conversation

@strawgate
Copy link
Contributor

Fixes #12488

Replaces closed PR: #12524

Benefits from:

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

Related issues

Screenshots

Overview

Overview

Concerning Agents

Problematic Agents

Agent Metrics

Agent Metrics

@strawgate strawgate requested a review from a team as a code owner February 14, 2025 19:04
@strawgate strawgate enabled auto-merge (squash) February 14, 2025 19:04
@strawgate strawgate disabled auto-merge February 14, 2025 19:04
@strawgate strawgate enabled auto-merge (squash) February 14, 2025 19:05
@elasticmachine
Copy link

💚 Build Succeeded

@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
75.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Feb 18, 2025
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on the interval, one title with "copy" in it.

But overall looks ok to me.

"y": 9
},
"panelIndex": "e3042c9b-987d-41fa-bc6b-0a73565ef278",
"title": "[Elastic Agent] Number of Integrations (copy)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is actually visible to the end user or not (didn't see it in screenshots), but we probably don't want copy in the title.

@@ -720,7 +4598,7 @@
"params": {
"dropPartials": true,
"includeEmptyRows": false,
"interval": "m"
"interval": "auto"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for anything that is a counter rate we want to keep the interval at "m" or "30s", we don't get the data very frequently and you don't want your interval to not have records in it to perform the counter rate, that leads to very odd looking graphs. Unless something in Kibana has fixed this.

Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strawgate do you have any tip/trick to add data to populate test the dashboard?

The screenshots look good, but I'm not sure I can easily generate data to populate all dashboards.

@strawgate
Copy link
Contributor Author

@strawgate do you have any tip/trick to add data to populate test the dashboard?

The screenshots look good, but I'm not sure I can easily generate data to populate all dashboards.

I just run a cgroup limited test agent in docker pointed at the cluster with the dashboards.

docker run --env FLEET_ENROLL=1 --memory 1gb --cpus 0.5  --env FLEET_URL=https://mycluster.fleet.us-central1.gcp.cloud.es.io:443  --env FLEET_ENROLLMENT_TOKEN=mykey  --rm docker.elastic.co/elastic-agent/elastic-agent:8.11.2

@leehinman
Copy link
Contributor

The screenshots look good, but I'm not sure I can easily generate data to populate all dashboards.

For the failed & rejects to Elasticsearch this is why I built https://github.com/elastic/mock-es, so you can leave the monitoring data going to a "real" elasticsearch, but have the integrations send to mock-es configured to have some errors. You do have to set the clusteruuid option in mock-es.

Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as Lee's comments are addressed.

@strawgate strawgate merged commit 92300b5 into elastic:main Feb 20, 2025
5 of 6 checks passed
@belimawr
Copy link
Contributor

Was automerge enabled? I totally missed that 🤦‍♂️

@elastic-vault-github-plugin-prod

Package elastic_agent - 2.1.0 containing this change is available at https://epr.elastic.co/package/elastic_agent/2.1.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:elastic_agent Elastic Agent Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[elastic_agent] Improvements to the Elastic Agent Metrics Overview dashboard

6 participants