Skip to content

Wire in Kafka read and write metrics #42537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
strawgate merged 2 commits into from
Jan 31, 2025
Merged

Wire in Kafka read and write metrics #42537

strawgate merged 2 commits into from
Jan 31, 2025

Conversation

@strawgate
Copy link
Contributor

@strawgate strawgate commented Jan 31, 2025

Wire in Kafka metrics so that we have request latency as well as incoming and outgoing bytes.

@strawgate strawgate requested a review from a team as a code owner January 31, 2025 15:18
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2025
@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @strawgate? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@strawgate strawgate added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jan 31, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 31, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2025
@strawgate strawgate added needs_team Indicates that the issue/PR needs a Team:* label backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Jan 31, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2025
@botelastic
Copy link

botelastic bot commented Jan 31, 2025

This pull request doesn't have a Team:<team> label.

@strawgate strawgate enabled auto-merge (squash) January 31, 2025 19:02
@strawgate strawgate mentioned this pull request Jan 31, 2025
Closed
5 tasks
@strawgate strawgate merged commit 2b8d554 into main Jan 31, 2025
142 checks passed
@strawgate strawgate deleted the add-kafka-metrics branch January 31, 2025 20:20
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@strawgate @mergify
Add Kafka output metrics (#42537)
944a731 
(cherry picked from commit 2b8d554)
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@strawgate @mergify
Add Kafka output metrics (#42537)
d3f60e7 
(cherry picked from commit 2b8d554)
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@strawgate @mergify
Add Kafka output metrics (#42537)
e0860cb 
(cherry picked from commit 2b8d554)
This was referenced Jan 31, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@strawgate @mergify
Add Kafka output metrics (#42537)
2436cb8 
(cherry picked from commit 2b8d554)
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
strawgate added a commit that referenced this pull request Jan 31, 2025
@mergify @strawgate
Add Kafka output metrics (#42537) (#42556)
addb26e 
(cherry picked from commit 2b8d554)

Co-authored-by: William Easton <[email protected]>
strawgate added a commit that referenced this pull request Jan 31, 2025
@mergify @strawgate
Add Kafka output metrics (#42537) (#42557)
f392454 
(cherry picked from commit 2b8d554)

Co-authored-by: William Easton <[email protected]>
strawgate added a commit that referenced this pull request Jan 31, 2025
@mergify @strawgate
Add Kafka output metrics (#42537) (#42555)
52563d9 
(cherry picked from commit 2b8d554)

Co-authored-by: William Easton <[email protected]>
@strawgate strawgate mentioned this pull request Jan 31, 2025
Merged
This was referenced Feb 4, 2025
Merged
Closed
Merged
Merged
strawgate added a commit that referenced this pull request Feb 4, 2025
@mergify @strawgate
Add Kafka output metrics (#42537) (#42558)
713f5f0 
(cherry picked from commit 2b8d554)

Co-authored-by: William Easton <[email protected]>
@strawgate strawgate mentioned this pull request Feb 4, 2025
Closed
5 tasks
@strawgate strawgate mentioned this pull request Feb 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@faec faec faec approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@strawgate strawgate

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@strawgate @elasticmachine @faec