-
Notifications
You must be signed in to change notification settings - Fork 240
tests: fix fastify TAV tests #4790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
17884f7
tests: fix fastify TAV tests
david-luna 5d703de
chore: update tav block
david-luna bea4f5b
Update .tav.yml
david-luna 8ff17fe
Update .tav.yml
david-luna 5b2100f
Merge branch 'main' into dluna-fix-fastify-tav
david-luna cf5906a
chore: remove tests for fastify@^1
david-luna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -420,12 +420,13 @@ restify: | |
| # - #1086 suggests [email protected] was a broken release, skip it. | ||
| # - [email protected] is broken: https://github.com/fastify/fastify/issues/3998#issuecomment-1153662513 | ||
| # - [email protected] - 4.16.2 (inclusive) are broken releases | ||
| # - [email protected] bumped to `pino@^9.0.0` which is using `tracingChannel` API. Breaking support for nodejs <18.19.0 | ||
| # - Do not run "test/sanitize-field-names/fastify.test.js" for older fastify, | ||
| # because the test file uses '@fastify/formbody', which only has versions | ||
| # for fastify >=3. | ||
| fastify: | ||
| - versions: '1.0.0 || 1.14.6' # subset of '1.x' | ||
| node: '>=6 <12' | ||
| node: '<15' | ||
trentm marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| commands: | ||
| - node test/instrumentation/modules/fastify/fastify.test.js | ||
| - node test/instrumentation/modules/fastify/async-await.test.js | ||
|
|
@@ -448,7 +449,7 @@ fastify: | |
| - node test/sanitize-field-names/fastify.test.js | ||
| - versions: | ||
| mode: max-7 | ||
| include: '>=4 <5' | ||
| include: '>=4 <4.26.2' | ||
| exclude: '4.0.1 || >=4.16.0 <=4.16.2' | ||
| peerDependencies: '@fastify/formbody@^7' | ||
| node: '>=14.6.0' | ||
|
|
@@ -457,6 +458,16 @@ fastify: | |
| - node test/instrumentation/modules/fastify/async-await.test.js | ||
| - node test/instrumentation/modules/fastify/set-framework.test.js | ||
| - node test/sanitize-field-names/fastify.test.js | ||
| - versions: | ||
| mode: max-7 | ||
david-luna marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| include: '>=4.26.2 <5' | ||
| peerDependencies: '@fastify/formbody@^7' | ||
| node: '>=18.19.0' | ||
| commands: | ||
| - node test/instrumentation/modules/fastify/fastify.test.js | ||
| - node test/instrumentation/modules/fastify/async-await.test.js | ||
| - node test/instrumentation/modules/fastify/set-framework.test.js | ||
| - node test/sanitize-field-names/fastify.test.js | ||
| - versions: | ||
| mode: max-7 | ||
| include: '>=5 <6' | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.