-
Notifications
You must be signed in to change notification settings - Fork 240
tests: fix fastify TAV tests #4790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
david-luna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test tav fastify
david-luna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test tav fastify
trentm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just some nits.
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
🔍 Preview links for changed docs |
fastifyTAV tests are failing for nodejs v14 with the followingpinois using tracing channel API which is available since nodejs v18.19.0. Fastify switched frompino@^8.17.0topino@^9.0.0in[email protected]. Latest version of pino (9.10.0) added tracing channels pinojs/pino#2281This PR updates TAV to adjust the node versions to use for testing fastify.
Checklist