Skip to content

Conversation

@david-luna
Copy link
Member

fastify TAV tests are failing for nodejs v14 with the following

node_tests-1  | # stderr:
node_tests-1  | # |TypeError: diagChan.tracingChannel is not a function
node_tests-1  | # |    at Object.<anonymous> (/app/node_modules/fastify/node_modules/pino/lib/tools.js:31:29)
node_tests-1  | # |    at Module._compile (internal/modules/cjs/loader.js:1114:14)
node_tests-1  | # |    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1143:10)
node_tests-1  | # |    at Module.load (internal/modules/cjs/loader.js:979:32)
node_tests-1  | # |    at Function.Module._load (internal/modules/cjs/loader.js:819:12)
node_tests-1  | # |    at Module.require (internal/modules/cjs/loader.js:1003:19)
node_tests-1  | # |    at Module.patchedRequire (/app/node_modules/require-in-the-middle/index.js:256:27)

pino is using tracing channel API which is available since nodejs v18.19.0. Fastify switched from pino@^8.17.0 to pino@^9.0.0 in [email protected]. Latest version of pino (9.10.0) added tracing channels pinojs/pino#2281

This PR updates TAV to adjust the node versions to use for testing fastify.

Checklist

@david-luna david-luna requested a review from a team as a code owner September 19, 2025 09:59
@github-actions
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member Author

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav fastify

Copy link
Member Author

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav fastify

trentm
trentm previously approved these changes Sep 19, 2025
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just some nits.

Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
trentm
trentm previously approved these changes Sep 19, 2025
@github-actions
Copy link

🔍 Preview links for changed docs

@david-luna david-luna merged commit f5d9b5a into main Sep 22, 2025
25 checks passed
@david-luna david-luna deleted the dluna-fix-fastify-tav branch September 22, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants