Validate support for GPU instance types#4243
Merged
cPu1 merged 5 commits intoeksctl-io:mainfrom Oct 18, 2021
Merged
Conversation
cPu1
force-pushed
the
gpu-ami-fix
branch
2 times, most recently
from
5540899 to
d56e08b
Compare
cPu1
force-pushed
the
gpu-ami-fix
branch
2 times, most recently
from
5fd1619 to
26b3f36
Compare
cPu1
force-pushed
the
gpu-ami-fix
branch
2 times, most recently
from
7f90a19 to
1e91749
Compare
Contributor
|
is this ready for review? (haven't been requested) |
Contributor
Author
Yes, it's ready for review. I missed your comment. |
Contributor
Author
|
This is a breaking change as explained in this pinned issue. |
aclevername
requested review from
Himangini,
Skarlso,
aclevername and
nikimanoledaki
Skarlso
reviewed
Oct 13, 2021
| import ( | ||
| "testing" | ||
|
|
||
| instanceutils "github.com/weaveworks/eksctl/pkg/utils/instance" |
Contributor
There was a problem hiding this comment.
Can you please move this down to the rest of the eksctl specific imports? :) Thanks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4238
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯