explorer: update toolbar items for new file and new folder#11429
Merged
vince-fugnitto merged 1 commit intomasterfrom Jul 16, 2022
Merged
explorer: update toolbar items for new file and new folder#11429vince-fugnitto merged 1 commit intomasterfrom
new file and new folder#11429vince-fugnitto merged 1 commit intomasterfrom
Conversation
vince-fugnitto
force-pushed
the
vf/explorer-toolbar
branch
from
82c0457 to
0536eec
Compare
colin-grant-work
approved these changes
Jul 15, 2022
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
The behavior is consistent with the testing steps and VSCode, and the command palette is clean with no duplicate items with the same label. 👍
The commit includes the following updates: - adds a `New File` toolbar item to replace the entry under the more context-menu. - adds a `New Folder` toolbar item to replace the entry under the more context-menu. - renamed `CommonCommands.NEW_FILE` to `CommonCommands.NEW_UNTITLED_FILE`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com> Co-authored-by: yiliang114 <1204183885@qq.com>
vince-fugnitto
force-pushed
the
vf/explorer-toolbar
branch
from
0536eec to
ffab1cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Closes: #11427.
Closes: #11425.
The pull-request adds dedicated items for both
New FileandNew Folderin theExplorer.How to test
New Filetriggers the new file with a dialog.New Untitled Fileopens an untitled file.New FileandNew Folderin the command palette.New Filefrom the top-levelFilemenu opens an untitled file.New Filetoolbar item exists in theExplorer- triggers a new file with a dialog.New Foldertoolbar item exists in theExplorer- triggers a new folder with a dialog.New FileandNew Folderdo not exist in theExplorer.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com
Co-authored-by: yiliang114 1204183885@qq.com