Skip to content

fix(navigator-contribution): close #11425, show NEW_FILE and NEW_FOLDER#11427

Closed
yiliang114 wants to merge 1 commit intoeclipse-theia:masterfrom
yiliang114:master
Closed

fix(navigator-contribution): close #11425, show NEW_FILE and NEW_FOLDER#11427
yiliang114 wants to merge 1 commit intoeclipse-theia:masterfrom
yiliang114:master

Conversation

@yiliang114
Copy link
Copy Markdown
Contributor

@yiliang114 yiliang114 commented Jul 14, 2022

NEW_FILE and NEW_FOLDER in front of navigator toolbar should show with icons like vscode

Signed-off-by: yiliang114 1204183885@qq.com

What it does

close #11425.

Make NEW_FILE and NEW_FOLDER Commands in front of navigator toolbar show at the beginning, instead of manually clicking to expand the menu.

Take NEW_FILE for example. At first I just added iconClass to CommonCommands.NEW_FILE, but it would make show its icon anywhere, such as in filetree right menu and File Menu. So I have forked CommonCommands.NEW_FILE and the previous configuration remains unchanged.

The final behavior:

image
image
image

How to test

  1. Hover mouse to projectName of treeview.
  2. Click Top Menu File.
  3. Right Click some files or folders on File Tree.
  4. Have a look with menu show behavior. What needs to be guaranteed most is these two commands in these places can run normally just like before.

Review checklist

Reminder for reviewers

… and NEW_FOLDER

NEW_FILE and NEW_FOLDER in front of navigator toolbar should show with icons like vscode

Signed-off-by: yiliang114 <1204183885@qq.com>
Copy link
Copy Markdown
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the way you duplicated commands is problematic and leads to multiple entries in the command palette:

Screen Shot 2022-07-14 at 2 51 23 PM

I'll create a pull-request to resolve the problem.

@yiliang114
Copy link
Copy Markdown
Contributor Author

Unfortunately the way you duplicated commands is problematic and leads to multiple entries in the command palette:

Screen Shot 2022-07-14 at 2 51 23 PM

I'll create a pull-request to resolve the problem.

Thank you for checking, i have ignored this place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NEW_FILE and NEW_FOLDER in front of navigator toolbar should show with icons like vscode

2 participants