Skip to content

Table: fix invalid restore of scroll top #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Knicksaas wants to merge 1 commit into
base: releases/26.2
Choose a base branch
from
+4 −0
Open

Table: fix invalid restore of scroll top #2055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eclipse-scout-core/src/table/Table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3332,6 +3332,10 @@ export class Table extends Widget implements TableModel, Filterable<TableRow> {
this.updateBuffer.one('complete', () => this._restoreScrollTop(scrollTop));
return;
}
if (this.scrollToSelection && this.selectedRows.length > 0) {
// No restore, scrollTop has been modified by the selected row
return;
}
// Cannot use setScrollTop because this.scrollTop may still have the old value so that _renderScrollTop would not been called
// This is because _onScroll is called asynchronously
this._setScrollTop(scrollTop);
Expand Down