Table: fix invalid restore of scroll top#2055
Open
Knicksaas wants to merge 1 commit intoreleases/26.2from
Open
Table: fix invalid restore of scroll top#2055Knicksaas wants to merge 1 commit intoreleases/26.2from
Knicksaas wants to merge 1 commit intoreleases/26.2from
Conversation
When the table rows are replaced, e.g. during the load of data, the scrollTop gets restored after the tableBuffer completed its work. This is not desired when scrollToSelection is active, because the scroll position depends on the selected row and can change during buffering. Therefore, the restore gets aborted when scrollToSelection is active. 450627
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the table rows are replaced, e.g. during the load of data, the scrollTop gets restored after the tableBuffer completed its work. This is not desired when scrollToSelection is active, because the scroll position depends on the selected row and can change during buffering. Therefore, the restore gets aborted when scrollToSelection is active.
450627