Optimize TCP connection logic #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of the original all_proxy environment variable check Signed-off-by: geekeryy <[email protected]>
Contributor
|
|
algitbot
pushed a commit
to alpinelinux/build-server-status
that referenced
this pull request
Nov 9, 2025
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/eclipse/paho.mqtt.golang](https://github.com/eclipse/paho.mqtt.golang) | require | patch | `v1.5.0` -> `v1.5.1` | --- ### Release Notes <details> <summary>eclipse/paho.mqtt.golang (github.com/eclipse/paho.mqtt.golang)</summary> ### [`v1.5.1`](https://github.com/eclipse-paho/paho.mqtt.golang/releases/tag/v1.5.1) [Compare Source](eclipse-paho/paho.mqtt.golang@v1.5.0...v1.5.1) This is a minor release incorporating changes made in the 14 months since v1.5.0 (including updating dependencies, and raising the Go version to 1.24). The changes are relatively minor but address a potential security issue, possible panic, enable users to better monitor the connection status, and incorporate a few optimisations. Thanks to those who have provided fixes/enhancements included in this release! Special thanks to Paul Gerste at [Sonar](https://www.sonarsource.com/) for reporting issue [#​730](eclipse-paho/paho.mqtt.golang#730) via the Eclipse security team (fix was implemented in MR [#​714](eclipse-paho/paho.mqtt.golang#714) in May, github issue created just prior to this release). This issue arose where a topic > 65535 bytes was passed to the `Publish` function, due to the way the data was encoded the topic could leak into the message body. Please see issue [#​730](eclipse-paho/paho.mqtt.golang#730) for further details. #### What's Changed - Updating go dependencies from pub and sub into the containers before building by [@​JefJrFigueiredo](https://github.com/JefJrFigueiredo) in [eclipse-paho#691](eclipse-paho/paho.mqtt.golang#691) - Optimize TCP connection logic by [@​geekeryy](https://github.com/geekeryy) in [eclipse-paho#713](eclipse-paho/paho.mqtt.golang#713) - Fields over 65535 bytes not encoded correctly by [@​MattBrittan](https://github.com/MattBrittan) in [eclipse-paho#714](eclipse-paho/paho.mqtt.golang#714) - Reduce slice allocations in route dispatch by [@​alespour](https://github.com/alespour) in [eclipse-paho#710](eclipse-paho/paho.mqtt.golang#710) - Add a ConnectionNotificationHandler by [@​RangelReale](https://github.com/RangelReale) in [eclipse-paho#727](eclipse-paho/paho.mqtt.golang#727) - Potential panic when using manual ACK by [@​MattBrittan](https://github.com/MattBrittan) in [eclipse-paho#729](eclipse-paho/paho.mqtt.golang#729) **Full Changelog**: <eclipse-paho/paho.mqtt.golang@v1.5.0...v1.5.1> </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> See merge request alpine/infra/build-server-status!22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize TCP connection logic, use proxy settings in the environment instead of the original all_proxy environment variable check
Supports both ALL_PROXY and all_proxy environment variables