fix: reduce slice allocations in route dispatch #710
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
handlersslice reused inrouter.matchAndDispatchin order to reduce slice (re)allocations. I think it is safe to reuse the slice since it is only used whenorder = true. Therefore, also added explicitif ordercheck for iterating over handlers, although it is safe to keep iterating over nil slice whenorder = false, of course.It is only a subtle optimization, but appeared when I profiled high-load scenario.
Benchmark with a single route:
before:
after:
I suppose with more routes, without reusing the slice, append would cause more re-allocations.