Update Bnd to 5.0 and JUnit 5 to 5.6 #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kriegfrj With the change to use the JUnit 5.6 jars (from maven central), the org.osgi.test.junit5 project runs the bnd-testing-maven-plugin goal but it fails to find and execute any tests. Previously, the output was So biz.aQute.tester.junit-platform is not finding any test cases to run when using JUnit 5.6. Can you look into this? |
Contributor
|
Figured it out - raised bndtools/bnd#3745 to document and track it. Unfortunate that 5.6 didn't come out a few weeks ago as we might have discovered this bug in time for the 5.0.0 release of Bnd... |
Contributor
Author
|
bndtools/bnd#3746 has a fix for Bnd to run the tests for JUnit 5.6. |
Signed-off-by: BJ Hargrave <[email protected]>
Bnd 5.0.0 does not find the tests with JUnit 5.6. So we still use the older JUnit 5 from the Oxygen repo for Bnd 5.0.0. See bndtools/bnd#3745. Signed-off-by: BJ Hargrave <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.