junit-platform: Fix Sub-request to handle plain DiscoverySelector #3746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This fix solves the problem identified in eclipse-osgi-technology/osgi-test#70 (comment). |
kriegfrj
reviewed
Jan 28, 2020
Contributor
kriegfrj
left a comment
kriegfrj
left a comment
There was a problem hiding this comment.
You have translated my English into Java with 100% accuracy (even correcting my English in the process)! Thanks! Just one comment, a bit of a micro-optimisation that you can possibly ignore.
...e.tester.junit-platform/src/aQute/tester/bundle/engine/discovery/BundleSelectorResolver.java
Show resolved
Hide resolved
Contributor
|
I'd also like to see a regression test or two - I can put these together and test against your patch. |
JUnit 5.5 changed to call getSelectorsByType with the base DiscoverySelector type which caused us to fail to substitute the OSGi ready selectors. We change to call the original request and then filter out the selector we will supply. We then add the selectors we will supply to the stream. Fixes #3745 Signed-off-by: BJ Hargrave <[email protected]>
Signed-off-by: BJ Hargrave <[email protected]>
This also fixed a bug where the bundle class loader was not used to find test methods from the Test-Cases header string. Signed-off-by: BJ Hargrave <[email protected]>
kriegfrj
added a commit
to kriegfrj/bnd
that referenced
this pull request
Jan 30, 2020
Signed-off-by: Fr Jeremy Krieg <[email protected]>
bjhargrave
added a commit
that referenced
this pull request
Jan 30, 2020
[junit-platform] Regression test for #3746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit 5.5 changed to call getSelectorsByType with the base
DiscoverySelector type which caused us to fail to substitute the OSGi
ready selectors.
We change to call the original request and then filter out the selector
we will supply. We then add the selectors we will supply to the stream.
Fixes #3745