Skip to content

Fix artifacts on bicubic interpolation #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix artifacts on bicubic interpolation #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb4dbb5
Fix mesh pattern artifacts on bicubic interpolation
ktgw0316 Sep 11, 2020
5a621f7
Fix pixelation artifacts on bicubic interpolation
ktgw0316 Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/core/src/main/java/org/eclipse/imagen/InterpolationBicubic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
*/
public final class InterpolationBicubic extends InterpolationTable {

private static final int PRECISION_BITS = 8;
private static final int PRECISION_BITS = 12;
Copy link
Contributor

@jodygarnett jodygarnett May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing with https://github.com/geosolutions-it/jai-ext/blob/master/jt-utilities/src/main/java/it/geosolutions/jaiext/interpolators/InterpolationBicubic.java which still has 8.


private static float[] dataHelper(int subsampleBits) {

Expand Down
2 changes: 1 addition & 1 deletion modules/core/src/main/java/org/eclipse/imagen/InterpolationBicubic2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
*/
public final class InterpolationBicubic2 extends InterpolationTable {

private static final int PRECISION_BITS = 8;
private static final int PRECISION_BITS = 12;

private static float[] dataHelper(int subsampleBits) {

Expand Down
12 changes: 6 additions & 6 deletions modules/core/src/main/java/org/eclipse/imagen/media/opimage/AffineBicubicOpImage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ private void byteLoop(RasterAccessor src,
float_fracx = fracx;
float_fracy = fracy;
frac_xx = float_fracx * (1.0F - float_fracx);
frac_yy = float_fracx * (1.0F - float_fracy);
frac_yy = float_fracy * (1.0F - float_fracy);
Copy link
Contributor

@jodygarnett jodygarnett May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing with https://github.com/geosolutions-it/jai-ext/blob/master/jt-affine/src/main/java/it/geosolutions/jaiext/affine/AffineBicubicOpImage.java#L4400

As the codebases have diverged and I do not see a similar fix in place.


s0 = s00 + ((s10 - s00) * float_fracx);
s1 = s01 + ((s11 - s01) * float_fracx);
Expand Down Expand Up @@ -584,7 +584,7 @@ private void intLoop(RasterAccessor src,
float_fracx = fracx;
float_fracy = fracy;
frac_xx = float_fracx * (1.0F - float_fracx);
frac_yy = float_fracx * (1.0F - float_fracy);
frac_yy = float_fracy * (1.0F - float_fracy);

s0 = s00 + ((s10 - s00) * float_fracx);
s1 = s01 + ((s11 - s01) * float_fracx);
Expand Down Expand Up @@ -850,7 +850,7 @@ private void shortLoop(RasterAccessor src,
float_fracx = fracx;
float_fracy = fracy;
frac_xx = float_fracx * (1.0F - float_fracx);
frac_yy = float_fracx * (1.0F - float_fracy);
frac_yy = float_fracy * (1.0F - float_fracy);

s0 = s00 + ((s10 - s00) * float_fracx);
s1 = s01 + ((s11 - s01) * float_fracx);
Expand Down Expand Up @@ -1115,7 +1115,7 @@ private void ushortLoop(RasterAccessor src,
float_fracx = fracx;
float_fracy = fracy;
frac_xx = float_fracx * (1.0F - float_fracx);
frac_yy = float_fracx * (1.0F - float_fracy);
frac_yy = float_fracy * (1.0F - float_fracy);

s0 = s00 + ((s10 - s00) * float_fracx);
s1 = s01 + ((s11 - s01) * float_fracx);
Expand Down Expand Up @@ -1379,7 +1379,7 @@ private void floatLoop(RasterAccessor src,
float_fracx = fracx;
float_fracy = fracy;
frac_xx = float_fracx * (1.0F - float_fracx);
frac_yy = float_fracx * (1.0F - float_fracy);
frac_yy = float_fracy * (1.0F - float_fracy);

s0 = s00 + ((s10 - s00) * float_fracx);
s1 = s01 + ((s11 - s01) * float_fracx);
Expand Down Expand Up @@ -1630,7 +1630,7 @@ private void doubleLoop(RasterAccessor src,
float_fracx = fracx;
float_fracy = fracy;
frac_xx = float_fracx * (1.0F - float_fracx);
frac_yy = float_fracx * (1.0F - float_fracy);
frac_yy = float_fracy * (1.0F - float_fracy);

s0 = s00 + ((s10 - s00) * float_fracx);
s1 = s01 + ((s11 - s01) * float_fracx);
Expand Down