Fix artifacts on bicubic interpolation #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodygarnett
reviewed
May 8, 2025
Contributor
jodygarnett
left a comment
jodygarnett
left a comment
There was a problem hiding this comment.
I am going to have to ask a more experienced member of the JAI-Ext team to review.
| public final class InterpolationBicubic extends InterpolationTable { | ||
|
|
||
| private static final int PRECISION_BITS = 8; | ||
| private static final int PRECISION_BITS = 12; |
Contributor
There was a problem hiding this comment.
| float_fracy = fracy; | ||
| frac_xx = float_fracx * (1.0F - float_fracx); | ||
| frac_yy = float_fracx * (1.0F - float_fracy); | ||
| frac_yy = float_fracy * (1.0F - float_fracy); |
Contributor
There was a problem hiding this comment.
As the codebases have diverged and I do not see a similar fix in place.
jodygarnett
requested changes
Jun 10, 2025
Contributor
jodygarnett
left a comment
jodygarnett
left a comment
There was a problem hiding this comment.
Revisit this change after JAI-Ext merged, check if still required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.