-
Notifications
You must be signed in to change notification settings - Fork 149
document support for creating module 'wrappers' for dependencies #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/Wrapping_dependencies.rst
Outdated
| which defines a so-called *"symbolic version"*. | ||
|
|
||
| This can be used to install a *"wrapper"* for a particular module, which can be useful in the context | ||
| of dependencies. For example, it can be used to avoid dependending on a specific version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I blame the bumpy train for this one...
docs/Wrapping_dependencies.rst
Outdated
|
|
||
| .. note:: For compatibility with the different modules tools supported by EasyBuild (see :ref:`modules_tool`), | ||
| the ``.modulerc`` file is always generated in Tcl syntax (for now), regardless of the module syntax | ||
| that is used for module files. Only Lmod 7.8 or more recent supports ``.modulerc.lua`` files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only Lmod 7.8 or later
docs/Wrapping_dependencies.rst
Outdated
| actual installation and generating a module file); in addition, it doesn't require updating/re-generating existing | ||
| module files that depend on the ``Java`` wrapper (since the version of the wrapper does not change) | ||
|
|
||
| Since ``ModuleRC`` is a generic easyblock , it can also be employed to install module "wrappers" for dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain in what way this is different from the above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "other dependencies" (or maybe "dependencies other than Java"), will fix
bartoldeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
going in, thanks @boegel ! |
see also:
.modulerc: add modulerc method to ModuleGenerator class easybuild-framework#2575ModuleRCeasyblock: add generic ModuleRC easyblock easybuild-easyblocks#1503Java/1.8wrapper: add Java 1.8 easyconfig that can be updated in-place to more recent JDK 1.8.x easybuild-easyconfigs#6712preview @ https://boegel-eb.readthedocs.io/en/java_wrapper/Wrapping_dependencies.html