add modulerc method to ModuleGenerator class #2575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules tool / Lmod version
ocaisa
requested changes
Sep 11, 2018
Member
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
LGTM and tests cover all modtool possibilities, one explanatory comment needed
boegel
commented
Sep 11, 2018
| COMMAND = 'lmod' | ||
| COMMAND_ENVIRONMENT = 'LMOD_CMD' | ||
| REQ_VERSION = '5.8' | ||
| REQ_VERSION = '6.6.3' |
Member
Author
There was a problem hiding this comment.
note: Lmod 6.0 or newer is needed to pick up on .modulerc files in module file subdirectory.
Older Lmod 6.x versions have bugs that make it incompatible with EasyBuild in other (unrelated ways), hence the more recent 6.x being required.
Lmod 6.6.3 is the latest 6.x release, which was released Nov 13th 2016 (close to 2 years old), so I don't expect this to be a big problem.
Also, this way EasyBuild is still compatible with both Lmod 6.x & 7.x...
This was referenced Sep 11, 2018
This was referenced Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.