move easybuild -> lib/easybuild and rename easybuild.sh -> easybuild #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside the __init__.py file in lib/ we change the sys.path variable to include the easybuild directory. This way, no special import changes have to be made.
Member
|
I'm not a big fan of moving all code to a 'lib' subdirectory. I realize the naming scheme doesn't allow having both the 'easybuild' directory and the 'easybuild' (formerly 'easybuild.sh') script in the same directory, but I think my preference would then go out to moving the script instead of the directory in the end, we want to provide an easybuild installer which put the main easybuild script in '/usr/local/bin' for example, and the easybuild code in '.../lib/python/site-packages/python-2.4' for example. Maybe rename 'easybuild.sh' to 'eb' instead? Or move 'easybuild.sh' to 'bin/easybuild' ? |
Now we move easybuild (former easybuild.sh) to eb and we keep the easybuild directory in place (instead of in lib/)
Member
|
This has my vote, can be merged. If this is merged, the documentation should be updated to reflect this change. Maybe we should keep a symlink named easybuild.sh to eb to avoid confusion? |
ghost
assigned
JensTimmerman
pushed a commit
that referenced
this pull request
Jul 10, 2012
renamed easybuild.sh to eb
boegel
referenced
this pull request
in boegel/easybuild-framework
Feb 19, 2013
fix option unit tests order (how was this ever correct?)
boegel
pushed a commit
that referenced
this pull request
Dec 16, 2013
clean up printing for --dry-run
boegel
pushed a commit
that referenced
this pull request
Feb 10, 2014
update with develop (to fix conflict), finish implementation of --modules-footer and add unit test for it
JensTimmerman
pushed a commit
that referenced
this pull request
Nov 6, 2014
fix log message in remove_file function
boegel
pushed a commit
that referenced
this pull request
Apr 2, 2015
enhance test that includes hard check for use of '$root' in module file
boegel
pushed a commit
that referenced
this pull request
Jul 9, 2015
add extra configuration options related to --job
boegel
pushed a commit
that referenced
this pull request
Jul 11, 2015
add unit tests for --package* (+ --skip)
boegel
pushed a commit
that referenced
this pull request
Aug 7, 2015
sync with develop & resolve conflicts
boegel
pushed a commit
that referenced
this pull request
Aug 4, 2016
fix help message for 'hidden' + use available auto-cleaned tmp dir in test
boegel
pushed a commit
that referenced
this pull request
Aug 21, 2017
rework support for --backup-modules
boegel
pushed a commit
that referenced
this pull request
Jul 6, 2018
…r-module-path clean up duplicate code
boegel
pushed a commit
that referenced
this pull request
Nov 16, 2018
different approach to avoid blind overwriting of existing files with --try-*
boegel
pushed a commit
that referenced
this pull request
Jan 15, 2019
enhance test for check_pr_eligible_to_merge to catch fixed bug w.r.t. last test report having to be successful
boegel
pushed a commit
that referenced
this pull request
Apr 12, 2023
relocate subprocess_popen_text + subprocess_terminate to easybuild.tools.run, import create_base_metaclass + mk_wrapper_baseclass from easybuild.base.wrapper in py2vs3/*.py
boegel
pushed a commit
that referenced
this pull request
Feb 10, 2025
add extra test case for make_module_req
boegel
added a commit
that referenced
this pull request
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside the init.py file in lib/ we change the sys.path variable to
include the easybuild directory. This way, no special import changes
have to be made.