Skip to content

Commit bbf2298

Browse files
authored
Merge pull request #8 from boegel/hidden_easyconfig
fix help message for 'hidden' + use available auto-cleaned tmp dir in test
2 parents 3f5feca + 27dc92a commit bbf2298

3 files changed

Lines changed: 4 additions & 6 deletions

File tree

easybuild/framework/easyconfig/default.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
'easyblock': [None, "EasyBlock to use for building; if set to None, an easyblock is selected "
8989
"based on the software name", BUILD],
9090
'easybuild_version': [None, "EasyBuild-version this spec-file was written for", BUILD],
91-
'hidden': [False, "Install module file as 'hidden' by prefixing its name with '.'", BUILD],
91+
'hidden': [False, "Install module file as 'hidden' by prefixing its version with '.'", BUILD],
9292
'installopts': ['', 'Extra options for installation', BUILD],
9393
'maxparallel': [None, 'Max degree of parallelism', BUILD],
9494
'parallel': [None, ('Degree of parallelism for e.g. make (default: based on the number of '

easybuild/tools/options.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ def override_options(self):
279279
'group': ("Group to be used for software installations (only verified, not set)", None, 'store', None),
280280
'group-writable-installdir': ("Enable group write permissions on installation directory after installation",
281281
None, 'store_true', False),
282-
'hidden': ("Install 'hidden' module file(s) by prefixing their name with '.'", None, 'store_true', False),
282+
'hidden': ("Install 'hidden' module file(s) by prefixing their version with '.'", None, 'store_true', False),
283283
'ignore-osdeps': ("Ignore any listed OS dependencies", None, 'store_true', False),
284284
'filter-deps': ("Comma separated list of dependencies that you DON'T want to install with EasyBuild, "
285285
"because equivalent OS packages are installed. (e.g. --filter-deps=zlib,ncurses)",

test/framework/toy_build.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -743,11 +743,10 @@ def test_toy_hidden_cmdline(self):
743743

744744
def test_toy_hidden_easyconfig(self):
745745
"""Test installing a hidden module using the 'hidden = True' easyconfig parameter."""
746-
tmpdir = tempfile.mkdtemp()
747746
# copy toy easyconfig file, and add hiding option to it
748747
ec_file = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'easyconfigs', 'toy-0.0.eb')
749-
shutil.copy2(ec_file, tmpdir)
750-
ec_file = os.path.join(tmpdir, 'toy-0.0.eb')
748+
shutil.copy2(ec_file, self.test_prefix)
749+
ec_file = os.path.join(self.test_prefix, 'toy-0.0.eb')
751750
write_file(ec_file, "\nhidden = True\n", append=True)
752751
self.test_toy_build(ec_file=ec_file, verify=False)
753752
# module file is hidden
@@ -758,7 +757,6 @@ def test_toy_hidden_easyconfig(self):
758757
# installed software is not hidden
759758
toybin = os.path.join(self.test_installpath, 'software', 'toy', '0.0', 'bin', 'toy')
760759
self.assertTrue(os.path.exists(toybin))
761-
shutil.rmtree(tmpdir)
762760

763761
def test_module_filepath_tweaking(self):
764762
"""Test using --suffix-modules-path."""

0 commit comments

Comments
 (0)