Skip to content

Fix f-string in rpath check and skip check for linked libs on symlinks #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 3 commits into from
Aug 27, 2025
Merged

Fix f-string in rpath check and skip check for linked libs on symlinks #4975

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43195ba
Fix f-string in rpath check
Flamefire Aug 11, 2025
4646ae1
Skip check for linked libs on symlinks
Flamefire Aug 11, 2025
1d657f2
add test for get_linked_libs_raw
boegel Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion easybuild/framework/easyblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3804,7 +3804,7 @@ def sanity_check_rpath(self, rpath_dirs=None, check_readelf_rpath=None):
out = get_linked_libs_raw(path)

if out is None:
msg = "Failed to determine dynamically linked libraries for {path}, "
msg = f"Failed to determine dynamically linked libraries for {path}, "
msg += "so skipping it in RPATH sanity check"
self.log.debug(msg)
else:
Expand Down
3 changes: 3 additions & 0 deletions easybuild/tools/systemtools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1118,6 +1118,9 @@ def get_linked_libs_raw(path):
or None for other types of files.
"""

if os.path.islink(path):
_log.debug(f"{path} is a symbolic link, so skipping check for linked libs")
return None
res = run_shell_cmd("file %s" % path, fail_on_error=False, hidden=True, output_file=False, stream_output=False)
if res.exit_code != EasyBuildExit.SUCCESS:
fail_msg = "Failed to run 'file %s': %s" % (path, res.output)
Expand Down