Fix f-string in rpath check and skip check for linked libs on symlinks #4975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`file` will return "symbolic link to libxxx" which will then skip the remaining checks. So do not bother running `file` on it which is much slower than an `islink` check.
boegel
requested changes
Aug 12, 2025
boegel
changed the title
Contributor
Author
|
Small followup after the discussion: #4988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://gist.github.com/boegelbot/1e87f59c5b2d74984a925e56a7adcb3d there is
There was a missed f-string causing this.
Additionally the
filecall (external tool) is unnecessary for symbolic links where it returnsThis will then not do any checks, so it can be skipped in a much cheaper way by using
islink, This change doesn't change existing behavior it just makes it obvious.This also means that
sanity_check_rpathcan/should be enhanced as theis_parent_pathcheck for outside symlinks doesn't make sense if no check is done for any symlinks yielding an additional "Failed to determine dynamically linked libraries for..." message.Shall we do that too?