Skip to content

Enhance RPATH sanity check to skip anything whose absolute path resolves to outside the install dir #4854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexming merged 4 commits into from
Apr 24, 2025
Merged

Enhance RPATH sanity check to skip anything whose absolute path resolves to outside the install dir #4854

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a5a598
Enhance rpath sanity check to skip anything whose absolute path
jfgrimm Apr 23, 2025
517cbcd
fix typo
jfgrimm Apr 23, 2025
8c89fb9
linting
jfgrimm Apr 23, 2025
2e939a6
Use self.log.info instead of self.log.debug
jfgrimm Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions easybuild/framework/easyblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3395,6 +3395,14 @@ def sanity_check_rpath(self, rpath_dirs=None, check_readelf_rpath=True):
self.log.debug(f"Sanity checking RPATH for files in {dirpath}")

for path in [os.path.join(dirpath, x) for x in os.listdir(dirpath)]:
# skip the check for any symlinks that resolve to outside the installation directory
if not is_parent_path(self.installdir, path):
realpath = os.path.realpath(path)
msg = (f"Skipping RPATH sanity check for {path}, since its absolute path {realpath} resolves to"
f" outside the installation directory {self.installdir}")
self.log.info(msg)
continue

self.log.debug(f"Sanity checking RPATH for {path}")

out = get_linked_libs_raw(path)
Expand Down