Enhance RPATH sanity check to skip anything whose absolute path resolves to outside the install dir #4854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves to outside of the installation directory
jfgrimm
commented
Apr 23, 2025
jfgrimm
commented
Apr 23, 2025
boegel
previously requested changes
Apr 23, 2025
boegel
changed the title
Add resolved and install dir paths to log message
jfgrimm
force-pushed
the
rpath-sanity-resolve-path
branch
from
db089ed to
2e939a6
Compare
Contributor
|
Merging, thanks @jfgrimm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should solve issues of the kind seen in: easybuilders/easybuild-easyconfigs#22789