add build_and_install_loop hooks to run before and after the install loop for individual easyconfigs
#4304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
boegel
changed the title
poised hook to run after easyconfigs are parsed but before the build starts
boegel
reviewed
Aug 2, 2023
XavierCS-dev
commented
Aug 7, 2023
easybuild/main.py
Outdated
| from easybuild.tools.github import new_pr_from_branch | ||
| from easybuild.tools.github import sync_branch_with_develop, sync_pr_with_develop, update_branch, update_pr | ||
| from easybuild.tools.hooks import START, END, load_hooks, run_hook | ||
| from easybuild.tools.hooks import LOOP, PRE_PREF, POST_PREF, START, END, load_hooks, run_hook |
Contributor
Author
There was a problem hiding this comment.
It will be used soon!
XavierCS-dev
changed the title
poised hook to run after easyconfigs are parsed but before the build startsbuild_and_install_loop hooks to run before and after the install loop for individual modules
branfosj
reviewed
Aug 8, 2023
branfosj
reviewed
Aug 8, 2023
Member
branfosj
left a comment
branfosj
left a comment
There was a problem hiding this comment.
Tabs instead of spaces after the ".
Member
|
@XavierCS-dev I assume this is good to go, but I'll let you mark it as "Ready for review" first... Are you up for also updating the documentation (https://docs.easybuild.io/hooks) accordingly, via a PR to https://github.com/easybuilders/easybuild-docs ? |
boegel
changed the title
build_and_install_loop hooks to run before and after the install loop for individual modulesbuild_and_install_loop hooks to run before and after the install loop for individual easyconfigs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POISEDBUILD_AND_INSTALL_LOOP hook to list of hooksPOISEDBUILD_AND_INSTALL_LOOP hook to run after easyconfigs are parsed + after install loopPOISEDBUILD_AND_INSTALL_LOOP hook an ordered list of the easyconfigs, to be processed by external tools.fixes #4303