Skip to content

Conversation

@Flamefire
Copy link
Contributor

This changes (type comma-separated list; default: ) to (type comma-separated list) similar to a default of None.

That changes the output of --help in the following places (done using diff over the output before and after):

                    Parse (additional) configfiles (type comma-separated list)
                    Enable dependency resolution, using easyconfigs in specified paths (type pathsep-separated list)
                    Additional paths to consider by robot for easyconfigs (--robot paths get priority) (type pathsep-separated list)
                    Additional locations to consider in --search (next to --robot and --robot-paths paths) (type pathsep-separated list)
                    Location(s) of extra or customized easyblocks (type comma-separated list)
                    Location(s) of extra or customized module naming schemes (type comma-separated list)
                    Location(s) of extra or customized toolchains or toolchain components (type comma-separated list)
--from-pr=PR#       Obtain easyconfigs from specified PR (type comma-separated list)
                    Include easyblocks from specified PR (type comma-separated list)
                    Accept EULA for specified software [DEPRECATED, use --accept-eula-for instead!] (type comma-separated list)
                    Accept EULA for specified software (type comma-separated list)
                    Silence specified deprecation warnings out of (python2, Lmod6, easyconfig, toolchain) (type comma-separated list)

BTW: A colon after "type" would probably be nice.

This changes `(type comma-separated list; default: )` to
`(type comma-separated list)` similar to a default of `None`.
@jfgrimm
Copy link
Member

jfgrimm commented Feb 24, 2023

seems sensible to me, given that we don't output the default None

@jfgrimm jfgrimm enabled auto-merge February 24, 2023 15:45
@jfgrimm jfgrimm merged commit 3c01a01 into easybuilders:develop Feb 24, 2023
@jfgrimm jfgrimm modified the milestones: 4.x, next release (4.7.1?) Feb 24, 2023
@Flamefire Flamefire deleted the default-str-list branch February 24, 2023 16:48
@boegel boegel changed the title Only print "default: " for str-list options if it is not empty. only print "default: " for configuration option of strlist type if default is not empty Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants