-
Notifications
You must be signed in to change notification settings - Fork 217
add support to silence deprecation warning for easyconfigs and toolchains #4207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to silence deprecation warning for easyconfigs and toolchains #4207
Conversation
Co-authored-by: Jasper <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Use the empty list as the default both in the option-add and the reverse dict. This way we can remove the post-processing step changing `None` to `[]`.
This changes `(type comma-separated list; default: )` to `(type comma-separated list)` similar to a default of `None`.
6f00f57 to
89eb00f
Compare
|
This now adds a new change: Only print "default: " for str-list options if it is not empty. That changes the output of
This can be discussed (if needed) in a separate PR I just opened with only that commit: #4220 |
…ramework into silence-ec-tc-deprecation
jfgrimm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We have the
silence_deprecation_warningsoption but that didn't support the warnings caused by deprecated ECs and toolchains.Add this and enhance the error message.
While at it also make the build_option return an empty list instead of
Noneso we can grep the code for any usage likeif 'foo' in build_option('silence_deprecation_warnings'):