add pre/post extension hook that is triggered before/after individual extension installations #4193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion installations) (fixes easybuilders#4191)
boegel
force-pushed
the
extension_hook
branch
from
b9abfd5 to
7c33ba3
Compare
lexming
reviewed
Jan 23, 2023
Contributor
lexming
left a comment
lexming
left a comment
There was a problem hiding this comment.
Looks good, my only concern is that pre_extension_hook and pre_extensions_hook are too similar. One typo and we will be executing code where we don't want to without any error. Following the name of the global, what about renaming pre_extension_hook to pre_installextension_hook ?
lexming
requested changes
Feb 15, 2023
boegel
force-pushed
the
extension_hook
branch
from
a4a3b2e to
6a46414
Compare
Contributor
|
Going in, thanks @boegel ! |
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding
EXTENSION_INSTALLtoHOOKS_NAMES, I noticed that the list of hooks wasn't being printed in order of being triggered, so I fixed that too...fixes #4191