Skip to content

add gfbf as subtoolchain of foss #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Micket merged 3 commits into from
Dec 17, 2022
Merged

add gfbf as subtoolchain of foss #4143

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1ba37b
add gfbf as subtoolchain of foss
boegel Dec 15, 2022
26e3e22
also pick up banned linked shared libs from golf and gfbf subtoolchai…
boegel Dec 16, 2022
029695e
don't try to collect list of banned linked shared libs for golf and g…
boegel Dec 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion easybuild/toolchains/foss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
from distutils.version import LooseVersion

from easybuild.toolchains.gompi import Gompi
from easybuild.toolchains.gfbf import Gfbf
from easybuild.toolchains.golf import Golf
from easybuild.toolchains.fft.fftw import Fftw
from easybuild.toolchains.linalg.flexiblas import FlexiBLAS
Expand All @@ -40,7 +41,7 @@
class Foss(Gompi, OpenBLAS, FlexiBLAS, ScaLAPACK, Fftw):
"""Compiler toolchain with GCC, OpenMPI, OpenBLAS, ScaLAPACK and FFTW."""
NAME = 'foss'
SUBTOOLCHAIN = [Gompi.NAME, Golf.NAME]
SUBTOOLCHAIN = [Gompi.NAME, Golf.NAME, Gfbf.NAME]
Copy link
Contributor

@akesandgren akesandgren Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need tio add Golf and Gfbf calls to the banned_linked_shaed_libs too

Copy link
Member Author

@boegel boegel Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akesandgren fixed in 26e3e22

Copy link
Member Author

@boegel boegel Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rolled back the changes done in commit 26e3e22 in commit 029695e, since it's not needed at all: the listed of banned linked shared libs is extended via the individual toolchain components (OpenBLAS/FlexiBLAS, ...) already!


def __init__(self, *args, **kwargs):
"""Toolchain constructor."""
Expand Down