Skip to content

add gfbf as subtoolchain of foss #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Micket merged 3 commits into from
Dec 17, 2022
Merged

add gfbf as subtoolchain of foss #4143

Micket merged 3 commits into from
Dec 17, 2022

Conversation

@boegel
Copy link
Member

@boegel boegel commented Dec 15, 2022 •
edited
Loading

(created using eb --new-pr)

Required for easybuilders/easybuild-easyconfigs#16912, so SciPy-bundle/2022.11-gfbf-2022.10 is considered as dependency for mpi4py/3.1.4-foss-2022.10

@boegel boegel added this to the next release (4.7.0) milestone Dec 15, 2022
@boegel boegel mentioned this pull request Dec 15, 2022
Merged
4 tasks
bartoldeman
bartoldeman previously approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

But CI fails for containers, looks unrelated...

@branfosj
Copy link
Member

branfosj commented Dec 16, 2022

But CI fails for containers, looks unrelated...

I've restarted the container tests.

akesandgren
akesandgren previously requested changes Dec 16, 2022
View reviewed changes
easybuild/toolchains/foss.py
"""Compiler toolchain with GCC, OpenMPI, OpenBLAS, ScaLAPACK and FFTW."""
NAME = 'foss'
SUBTOOLCHAIN = [Gompi.NAME, Golf.NAME]
SUBTOOLCHAIN = [Gompi.NAME, Golf.NAME, Gfbf.NAME]
Copy link
Contributor

@akesandgren akesandgren Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need tio add Golf and Gfbf calls to the banned_linked_shaed_libs too

Copy link
Member Author

@boegel boegel Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akesandgren fixed in 26e3e22

Copy link
Member Author

@boegel boegel Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rolled back the changes done in commit 26e3e22 in commit 029695e, since it's not needed at all: the listed of banned linked shared libs is extended via the individual toolchain components (OpenBLAS/FlexiBLAS, ...) already!

@boegel
don't try to collect list of banned linked shared libs for golf and g…
029695e 
…fbf toolchains, already handled via separate toolchain components like OpenBLAS/FlexiBLAS
@easybuilders easybuilders deleted a comment from boegelbot Dec 17, 2022
@easybuilders easybuilders deleted a comment from boegelbot Dec 17, 2022
Micket
Micket approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 04c7161 into easybuilders:develop Dec 17, 2022
@boegel boegel deleted the 20221215214615_new_pr_AtoCRljOZf branch December 18, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

@akesandgren akesandgren akesandgren left review comments

@bartoldeman bartoldeman bartoldeman left review comments

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@boegel @branfosj @Micket @akesandgren @bartoldeman