fixes required to avoid breaking Cray support #3008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues popped up when testing current
developon CSCS' Piz Daint:The
CrayToolchaineasyblock needs a tweak to avoid loading the modules for the dependencies specified in easyconfig file to install a new toolchain (for exampleCrayGNUorCrayIntel)This is required because of the change in semantics of the
dummytoolchain (which is now an alias for the newsystemtoolchain), where using adummyversion no longer implies not loading the modules for the toolchain and dependencies in the build environment (see also deprecate 'dummy' toolchain, replace with 'system' toolchain #2877).Doing so is a) not needed at all to install a
Cray*toolchain, b) requires more than a simplemodule load, since it's likely that modules that loaded in the default environment on a Cray system will trigger a conflict, for example:The
prepare_stephas been updated in 42a166b to allow not loading the modules for the toolchain & dependencies (the default is of course unchanged), which can be leveraged easily in theCrayToolchaineasyblock.The output of
modulecmd python loadsometimes includes a faultysourcecommand using some versions of Cray's environment modules 3.2.10.x (certainly withmodules/3.2.10.6).The
run_modulemethod ofEnvironmentModulesCclass has been customized to strip out these faultysourcecommands, which fixes problems like:cc @gppezzi @victorusu