deprecate 'dummy' toolchain, replace with 'system' toolchain #2877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erywhere (incl. renaming --add-dummy-to-minimal-toolchains to --add-system-to-minimal-toolchains)
…ed 'dummy' toolchain
…ted by deprecating dummy toolchain
…cating dummy toolchain
…eck whether easyconfig file is generated, to avoid running into GCC 4.9.3-* easyconfigs that have a versionsuffix as well
…ork into system_toolchain
…ents in tests for system toolchain
…p vs indirect non-hidden dep of toy/.0.0-deps by specifying dummy test module instead
houndci-bot
reviewed
May 13, 2019
houndci-bot
reviewed
May 13, 2019
houndci-bot
reviewed
May 13, 2019
houndci-bot
reviewed
May 13, 2019
This was referenced May 13, 2019
akesandgren
reviewed
May 15, 2019
akesandgren
reviewed
May 15, 2019
akesandgren
reviewed
May 15, 2019
akesandgren
reviewed
May 15, 2019
akesandgren
reviewed
May 15, 2019
wpoely86
approved these changes
May 15, 2019
This was referenced Aug 7, 2019
This was referenced Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #1181)
The main motivation of this change is i) to get rid of the silly/meaningless '
dummy' name, ii) to get rid of the confusing behavior of thedummytoolchain of not loading dependencies in the build environment when 'dummy' is used as a toolchain version (cfr. https://easybuild.readthedocs.io/en/latest/Writing_easyconfig_files.html#loading-of-modules-for-dependencies-with-a-dummy-toolchain).A big part of this PR is replacing the use of '
dummy' with 'system' throughout the code base and tests, so let me highlight the main changes:A new
systemtoolchain was introduced (see alsoSystemtoolchain definition +SystemCompilercompiler used by it).In contrast with the
dummytoolchain, theversionof thesystemtoolchain is totally meaningless (so no more special behavior like we had with using 'dummy' as aversionfor thedummytoolchain).The use of the
dummytoolchain is deprecated: it will produce a big fat warning in EasyBuild 4.x, and will result in an error being raised starting with EasyBuild 5.0 (seeToolchain.__init__ineasybuild/tools/toolchain/toolchain.py).In addition, whenever the
dummytoolchain is specified, it will be replaced by thesystemtoolchain under the coversThe
--add-dummy-to-minimal-toolchainsconfiguration option has been renamed to--add-system-to-minimal-toolchains(so--add-dummy-to-minimal-toolchainsis no longer a valid configuration option).A new function
is_system_toolchain(+ utility methodToolchain.is_system_toolchain()) has been added, which should be used wherever we need to check whether or not a system toolchain is used (rather than checking the toolchain name againstDUMMY_TOOLCHAIN_NAME).A new constant
SYSTEMwas added which allows for usingtoolchain = SYSTEMin easyconfig files, to make the use of a system toolchain stand out a bit more, and to make it cleaner (compared to usingtoolchain = {'name': 'system', 'version': 'system'}.A new (internal) constant
SYSTEM_TOOLCHAIN_NAMEwas introduced, equivalent withDUMMY_TOOLCHAIN_NAME(but easyblocks should be updated to useis_system_toolchaininstead).dummyis filtered from the output of--list-toolchains(since it's deprecated)