Treat components like extensions in fetch_step#2855
Closed
ocaisa wants to merge 4 commits intoeasybuilders:developfrom
Closed
Treat components like extensions in fetch_step#2855ocaisa wants to merge 4 commits intoeasybuilders:developfrom
ocaisa wants to merge 4 commits intoeasybuilders:developfrom
Conversation
ocaisa
commented
May 3, 2019
easybuild/framework/easyblock.py
Outdated
| default_source_tmpl = resolve_template('%(name)s-%(version)s.tar.gz', template_values) | ||
| fn = ext_options.get('source_tmpl', default_source_tmpl) | ||
| if components: | ||
| fn = resolve_template(extra_src['options'].get('sources', default_source_tmpl)[0], |
Member
Author
There was a problem hiding this comment.
Problem here is that for components this is a list, there may be more than one source file
Member
Author
|
Injecting checksums into a bundle does not work, their syntax is very similar (the same even) to extensions, but they do have have the same status so that makes it hard |
Member
Author
|
Closing this since there is a more straightforward solution to the particular problem in easybuilders/easybuild-easyblocks#1711 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.