Skip to content

Attach source_urls directly to sources for components in generic Bundle easyblock#1711

Merged
boegel merged 6 commits intoeasybuilders:developfrom
ocaisa:bundle_sourcelist
May 7, 2019
Merged

Attach source_urls directly to sources for components in generic Bundle easyblock#1711
boegel merged 6 commits intoeasybuilders:developfrom
ocaisa:bundle_sourcelist

Conversation

@ocaisa
Copy link
Member

@ocaisa ocaisa commented May 6, 2019

Fixes #1674

@akesandgren
Copy link
Contributor

Looks sane, should there be a test for this too?

@ocaisa
Copy link
Member Author

ocaisa commented May 6, 2019

There aren't specific tests for functionality within individual easyblocks are there? There are some tests for --module-only but other than that I can't find any. I don't know if I'm familiar enough with the testing to set that all up from scratch.

@boegel
Copy link
Member

boegel commented May 6, 2019

There's no easy way to come up with a test for this in the easyblocks test suite, the only real way to test is to use this updated Bundle easyblock for easyconfigs that use it (+ use components), which is X11, FALCON and recent PyQt(5) easyconfigs.

That, and checking whether the problem @klust reported is actually fixed.

@boegel boegel changed the title Attach source_urls directly to sources for components Attach source_urls directly to sources for components in generic Bundle easyblock May 6, 2019
@ocaisa
Copy link
Member Author

ocaisa commented May 6, 2019

I checked this against X11 and against the easyconfig that prompted the PR (as well as the easyconfig solution for that where the source was a dict), all worked with the latest version.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocaisa I was a bit confused when reviewing this by the cfg name, maybe we should rename it to comp_cfg?

@ocaisa
Copy link
Member Author

ocaisa commented May 7, 2019

@boegel I did the renaming

@boegel
Copy link
Member

boegel commented May 7, 2019

re-tested with X11, PyQt, PyQt5 and FALCON bundles that use components, all's good...

Thanks a lot for looking into this @ocaisa!

@boegel boegel merged commit d6d6d32 into easybuilders:develop May 7, 2019
@ocaisa ocaisa deleted the bundle_sourcelist branch October 27, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants