-
Notifications
You must be signed in to change notification settings - Fork 763
{numlib}[gfbf/2025b] Basix v0.10.0, DOLFINx v0.10.0, FFCx v0.10.0, ... #24393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
{numlib}[gfbf/2025b] Basix v0.10.0, DOLFINx v0.10.0, FFCx v0.10.0, ... #24393
Conversation
…foss-2025b.eb, FFCx-0.10.0-gfbf-2025b.eb, gmsh-4.14.1-foss-2025b.eb, UFL-2025.2.0-gfbf-2025b.eb
Updated software
|
|
Test report by @sassy-crick |
|
@boegelbot please test @ jsc-zen3 |
|
@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 3467673710 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
| builddependencies = [ | ||
| ('CMake', '3.31.8'), | ||
| ('scikit-build-core', '0.11.5'), | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| builddependencies = [ | |
| ('CMake', '3.31.8'), | |
| ('scikit-build-core', '0.11.5'), | |
| ] | |
| builddependencies = [ | |
| ('scikit-build-core', '0.11.5'), | |
| ] |
scikit-build-core already has a dependency on CMake 4.0. No need to provide CMake 3.31.8 here. In addition, this creates a conflict, since we load two different CMake versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. I did not check for that. I have addressed that now and will upload it when I done all the suggested changes. Thanks!
| dependencies = [ | ||
| ('Python', '3.13.5'), | ||
| ('SciPy-bundle', '2025.07'), | ||
| ('pybind11', '3.0.0'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a builddependency. I don't think Basix will build additional code with pybind11 on the fly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I have changed it and will upload it once I am done with the other changes. Thanks!
| checksums = ['43ebfaf89fcb7809b11b94ba3e8ea8e56a99d724a45c51e99e39a35c577c441e'] | ||
|
|
||
| builddependencies = [ | ||
| ('CMake', '3.31.8'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ('CMake', '3.31.8'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed it and will upload it once I am done with the other changes. Thanks!
| checksums = ['fa27e2dc68988cbf9aca537eb5a58483f75cc719c1a383713b7f8cca49844ff9'] | ||
|
|
||
| builddependencies = [ | ||
| ('CMake', '3.31.8'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ('CMake', '3.31.8'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not better to explicitly load cmake ? Just wondering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed it and will upload it once I am done with the other changes. Thanks!
| dependencies = [ | ||
| ('Python', '3.13.5'), | ||
| ('SciPy-bundle', '2025.07'), | ||
| ('pybind11', '3.0.0'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
builddependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed it and will upload it once I am done with the other changes. Thanks!
| checksums = ['300cbb74b6fb88062aba70b1f5f31a8980177a4af415221a16ec8c0aa1d72afd'] | ||
|
|
||
| builddependencies = [ | ||
| ('CMake', '3.31.8'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ('CMake', '3.31.8'), | |
| ('CMake', '4.0.3'), |
Please use this version by default. If this really doesn't work, then we should drop to the older version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed it and will upload it once I am done with the other changes. Thanks!
| checksums = ['3d7590a78c280a12d822d4f4e7bd49e081ca260a2a3d442f1bf31dd23b79e1bf'] | ||
|
|
||
| builddependencies = [ | ||
| ('CMake', '3.31.8'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ('CMake', '3.31.8'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed it and will upload it once I am done with the other changes. Thanks!
| dependencies = [ | ||
| ('Python', '3.13.5'), | ||
| ('SciPy-bundle', '2025.07'), | ||
| ('pybind11', '3.0.0'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
builddependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed it and will upload it once I am done with the other changes. Thanks!
|
@boegelbot please test @ jsc-zen3 |
|
@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 3468521854 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @sassy-crick |
|
Test report by @boegelbot |
|
Looks good to me now at first glance, but I'm not familiar at all with the packages 😄 That's something to the maintainers to decide... |
|
Test report by @Thyre |
|
Test report by @Thyre |
(created using
eb --new-pr)Requires:
Based on the work from PR #22700 and #22422
I would suggest once this PR is merged, to apply the changes to the original PRs too.