{lib}[GCCcore/14.3.0] spdlog-1.15.3 #24391

sassy-crick · 2025-10-29T09:51:30Z

(created using eb --new-pr)

Added the build of the dynamic libraries which are needed for some software packages, and added the one test job they provide.
Happy to backport to the already existing EC if required.

Thyre · 2025-10-29T09:55:46Z

The build of shared libraries was added in #24310, but enabling the tests is probably a good idea.

We shouldn't remove building with PIC though, as this can cause issues when using the library later on.

sassy-crick · 2025-10-29T10:04:50Z

The build of shared libraries was added in #24310, but enabling the tests is probably a good idea.

We shouldn't remove building with PIC though, as this can cause issues when using the library later on.

Ah, that PR has slipped through when I was working on that. I agree with the PIC, I will update that.

sassy-crick · 2025-10-29T10:39:38Z

@boegelbot please test @ jsc-zen3

boegelbot · 2025-10-29T10:40:12Z

@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24391 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24391 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 8572

Test results coming soon (I hope)...

- notification for comment with ID 3460840222 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-10-29T10:42:28Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/649dec7ed4efeeac3d9a39b663aa6207 for a full test report.

sassy-crick · 2025-10-29T11:17:14Z

@boegelbot please test @ jsc-zen3

boegelbot · 2025-10-29T11:20:09Z

@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24391 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24391 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 8575

Test results coming soon (I hope)...

- notification for comment with ID 3460993457 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-10-29T11:22:28Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/7ad4fe7f0338c13fb9ced4b12bd5b382 for a full test report.

Thyre · 2025-10-29T11:54:06Z

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jrc0901.jureca - Linux Rocky Linux 9.6, AArch64, ARM UNKNOWN (neoverse_v2), 1 x NVIDIA NVIDIA GH200 480GB, 580.95.05, Python 3.9.21
See https://gist.github.com/Thyre/c53911f5315564afd35df448131061d2 for a full test report.

Thyre · 2025-10-29T12:01:15Z

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
ZAM054 - Linux Zorin OS 18, x86_64, 12th Gen Intel(R) Core(TM) i7-1260P (skylake), 1 x NVIDIA NVIDIA GeForce MX550, 580.95.05, Python 3.12.3
See https://gist.github.com/Thyre/a63144ff3b6977e63ddb675fc9f9a614 for a full test report.

Crivella · 2025-10-29T12:29:38Z

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/cda51d350fca9c6cdf4ba28e4a625c5b for a full test report.

Thyre · 2025-10-29T12:32:25Z

easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-14.3.0.eb

-_shared_configopts = " ".join([
-    "-DSPDLOG_BUILD_SHARED=ON",
-    "-DSPDLOG_BUILD_PIC=ON",
-])
+_base_configopts = ' -DSPDLOG_BUILD_TESTS=ON'
+configopts = [f'{_base_configopts} -DSPDLOG_BUILD_SHARED={x}' for x in ('OFF', 'ON')]


Not sure if we want to remove SPDLOG_BUILD_PIC=ON

It is doing what we are already doing in the CMake EB when setting the fpic TC option to true

https://github.com/gabime/spdlog/blob/486b55554f11c9cccc913e11a87085b2a91f706f/CMakeLists.txt#L149-L151

But i would still leave it there to ensure that we follow what the source CMake dictates in case they add more stuff in the future

I was not aware of the other PR so mine was based on a different 'template' and thus, I did not remove it, I simply never added it. I have put that back, thanks for finding this!

Crivella · 2025-10-29T12:34:28Z

easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-14.3.0.eb

 sanity_check_paths = {
-    'files': ['include/%(name)s/%(name)s.h', 'lib/lib%(name)s.a', f'lib/lib%(name)s.{SHLIB_EXT}'],
+    'files': [f'include/{name}/{name}.h', 'lib/libspdlog.a', 'lib/libspdlog.%s' % SHLIB_EXT],
    'dirs': ['lib64/cmake', 'lib64/pkgconfig'],


Would keep consistent usage of f-strings without re-introducing old % formatting.

Well, I done my PR without being aware of what you already done @Crivella . So that is why I had already the f-string for the bit I knew how to do it, but I was not sure how to do it for the SHLIB_EXT bit. So now that is consistent, thanks fo your help.

Crivella · 2025-10-29T13:42:27Z

easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-14.3.0.eb


 sanity_check_paths = {
-    'files': ['include/%(name)s/%(name)s.h', 'lib/lib%(name)s.a', f'lib/lib%(name)s.{SHLIB_EXT}'],
+    'files': [f'include/{name}/{name}.h', 'lib/libspdlog.a', 'lib/libspdlog.%s' % SHLIB_EXT],


Suggested change

'files': [f'include/{name}/{name}.h', 'lib/libspdlog.a', 'lib/libspdlog.%s' % SHLIB_EXT],

'files': ['include/%(name)s/%(name)s.h', 'lib/lib%(name)s.a', f'lib/lib%(name)s.{SHLIB_EXT}'],

%(name)s are EB templates. I do not expect it to ever be different from name in the EC but i would keep it as such w.r.t other ECs

SHLIB_EXT is also an EB variable that will be injected in the EC. with python linting it appears undefined but it will be replaced when the EC is loaded

My understanding was the %(foo)s is better replaced with f'{foo}' as it is easier to read. Did I get that wrong?

They are not equivalent. What i was referring to is the % used to place SHLIB_EXT in the string.

%(name)s is not a string formatting but an EB template that is replaced by EB when reading the EasyConfig.

The ones under https://docs.easybuild.io/version-specific/easyconfig-templates/#template-namesvalues-as-set-in-easyconfig are probably the only trivial ones that will be equivalent to the value in the EC

EDIT: for context we already have some {name} in EB but templates are the majority

(easybuild-dev) crivella@crivella-desktop:~/Documents/GIT/easybuild-easyconfigs $ grep -l -R '{name}' * | wc -l 124 (easybuild-dev) crivella@crivella-desktop:~/Documents/GIT/easybuild-easyconfigs $ grep -l -R '%(name)s' * | wc -l 2249

Crivella · 2025-10-29T14:01:54Z

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/fd0f59573ee93082e6c2dc4924b45bef for a full test report.

Crivella

LGTM

Crivella · 2025-10-29T14:10:12Z

Going in, thanks @sassy-crick!

…ial missing PIC in static library

`spdlog` apply changes from #24391 to all versions.

Dynamic library build and test job added

7d567ae

github-actions bot added the change label Oct 29, 2025

Thyre added the 2025b issues & PRs related to 2025b common toolchains label Oct 29, 2025

sassy-crick changed the title ~~Dynamic library build and test job added~~ {lib}[GCCcore-14.3.0] spdlog-1.15.3 Oct 29, 2025

sassy-crick changed the title ~~{lib}[GCCcore-14.3.0] spdlog-1.15.3~~ {lib}[GCCcore/14.3.0] spdlog-1.15.3 Oct 29, 2025

sassy-crick mentioned this pull request Oct 29, 2025

{numlib}[gfbf/2025b] Basix v0.10.0, DOLFINx v0.10.0, FFCx v0.10.0, ... #24393

Open

3 tasks

PIC support added

efaa579

sassy-crick added the ready-to-review label Oct 29, 2025

Thyre reviewed Oct 29, 2025

View reviewed changes

Crivella reviewed Oct 29, 2025

View reviewed changes

sassy added 2 commits October 29, 2025 13:45

check for shared/static libs added, missing configopts added

4a9d515

configopts corrected

cdcaaec

Crivella approved these changes Oct 29, 2025

View reviewed changes

Crivella added this to the next release (5.2.0?) milestone Oct 29, 2025

Crivella removed the change label Oct 29, 2025

Crivella merged commit 098029d into easybuilders:develop Oct 29, 2025
8 checks passed

Crivella added a commit to Crivella/easybuild-easyconfigs that referenced this pull request Oct 29, 2025

Apply changes from easybuilders#24391 to all versions. Als fix potent…

9e773d1

…ial missing PIC in static library

sassy-crick deleted the 20251029095129_new_pr_spdlog1153 branch October 29, 2025 18:09

Micket added a commit that referenced this pull request Oct 29, 2025

Merge pull request #24400 from Crivella/fix-spdlog-staticpic

64b7b34

`spdlog` apply changes from #24391 to all versions.

	'files': [f'include/{name}/{name}.h', 'lib/libspdlog.a', 'lib/libspdlog.%s' % SHLIB_EXT],
	'files': ['include/%(name)s/%(name)s.h', 'lib/lib%(name)s.a', f'lib/lib%(name)s.{SHLIB_EXT}'],

{lib}[GCCcore/14.3.0] spdlog-1.15.3 #24391

{lib}[GCCcore/14.3.0] spdlog-1.15.3 #24391

Uh oh!

Conversation

sassy-crick commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Thyre commented Oct 29, 2025

Uh oh!

sassy-crick commented Oct 29, 2025

Uh oh!

sassy-crick commented Oct 29, 2025

Uh oh!

boegelbot commented Oct 29, 2025

Uh oh!

boegelbot commented Oct 29, 2025

Uh oh!

sassy-crick commented Oct 29, 2025

Uh oh!

boegelbot commented Oct 29, 2025

Uh oh!

boegelbot commented Oct 29, 2025

Uh oh!

Thyre commented Oct 29, 2025

Uh oh!

Thyre commented Oct 29, 2025

Uh oh!

Crivella commented Oct 29, 2025

Uh oh!

Thyre Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Crivella Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

sassy-crick Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Crivella Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

sassy-crick Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Crivella Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

sassy-crick Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Crivella Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Crivella commented Oct 29, 2025

Uh oh!

Crivella left a comment

Choose a reason for hiding this comment

Uh oh!

Crivella commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sassy-crick commented Oct 29, 2025 •

edited

Loading

Crivella Oct 29, 2025 •

edited

Loading