Skip to content

{numlib}[foss/2023a] Suitesparse v7.1.0 #18857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akesandgren merged 4 commits into from
Nov 8, 2023
Merged

{numlib}[foss/2023a] Suitesparse v7.1.0 #18857

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b53d9ce
adding easyconfigs: SuiteSparse-7.1.0-foss-2023a.eb
Sep 25, 2023
ec1476b
Add pkgconf build dependency
appolloford Nov 6, 2023
358a027
Remove unused dependencies
appolloford Nov 7, 2023
ac9f8b0
Merge branch 'develop' of https://github.com/easybuilders/easybuild-e…
akesandgren Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions easybuild/easyconfigs/s/SuiteSparse/SuiteSparse-7.1.0-foss-2023a.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name = 'SuiteSparse'
version = '7.1.0'

homepage = 'https://faculty.cse.tamu.edu/davis/suitesparse.html'
description = """SuiteSparse is a collection of libraries to manipulate sparse matrices."""

toolchain = {'name': 'foss', 'version': '2023a'}
toolchainopts = {'unroll': True, 'pic': True}

source_urls = ['https://github.com/DrTimothyAldenDavis/SuiteSparse/archive']
sources = ['v%(version)s.tar.gz']
checksums = ['4cd3d161f9aa4f98ec5fa725ee5dc27bca960a3714a707a7d12b3d0abb504679']

builddependencies = [
('CMake', '3.26.3'),
('pkgconf', '1.9.5'),
]

dependencies = [
('MPFR', '4.2.0'),
]

prebuildopts = 'CMAKE_OPTIONS="-DCMAKE_INSTALL_PREFIX=%(installdir)s -DBLA_VENDOR=FlexiBLAS"'
Copy link
Member

@boegel boegel Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appolloford Can't we enhance the SuiteSparse easyblock to also take care of this automatically?

At least the -DCMAKE_INSTALL_PREFIX=%(installdir)s should be done automatically, as accidentally not including this in the easyconfig would be rather dramatic...

Even the -DBLA_VENDOR part can be derived automatically from the toolchain.

We could still leave the door open to specify custom options for CMake in the easyconfig, but I would do that via a direct custom easyconfig parameter that is supported by the SuiteSparse custom easyblock, like:

cmake_options = "..."

If cmake_options is set, that value could then also be included in the CMAKE_OPTIONS="..." that the SuiteSparse easyblock constructs?

Copy link
Contributor

@akesandgren akesandgren Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but it will require a somewhat larger rewrite of the easyblock. It would need to find each dir which should be built with CMake etc since there currently is no top level CMakeLists.txt that does the right thing.

I didn't want to delay the easyblock PR to make this happen.

Copy link
Contributor Author

@appolloford appolloford Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make the CMAKE_OPTIONS set in easyblock, and actually I tried that before. I did not know how to add a local option for a particular easyconfigs, but I will do it.


moduleclass = 'numlib'