-
Notifications
You must be signed in to change notification settings - Fork 772
{numlib}[foss/2023a] Suitesparse v7.1.0 #18857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{numlib}[foss/2023a] Suitesparse v7.1.0 #18857
Conversation
|
Test report by @akesandgren |
easybuild/easyconfigs/s/SuiteSparse/SuiteSparse-7.1.0-foss-2023a.eb
Outdated
Show resolved
Hide resolved
|
Test report by @akesandgren |
easybuild/easyconfigs/s/SuiteSparse/SuiteSparse-7.1.0-foss-2023a.eb
Outdated
Show resolved
Hide resolved
akesandgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Going in, thanks @appolloford! |
…asyconfigs into 20230925102922_new_pr_SuiteSparse710
|
Going in, thanks @appolloford! |
| ('MPFR', '4.2.0'), | ||
| ] | ||
|
|
||
| prebuildopts = 'CMAKE_OPTIONS="-DCMAKE_INSTALL_PREFIX=%(installdir)s -DBLA_VENDOR=FlexiBLAS"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@appolloford Can't we enhance the SuiteSparse easyblock to also take care of this automatically?
At least the -DCMAKE_INSTALL_PREFIX=%(installdir)s should be done automatically, as accidentally not including this in the easyconfig would be rather dramatic...
Even the -DBLA_VENDOR part can be derived automatically from the toolchain.
We could still leave the door open to specify custom options for CMake in the easyconfig, but I would do that via a direct custom easyconfig parameter that is supported by the SuiteSparse custom easyblock, like:
cmake_options = "..."If cmake_options is set, that value could then also be included in the CMAKE_OPTIONS="..." that the SuiteSparse easyblock constructs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but it will require a somewhat larger rewrite of the easyblock. It would need to find each dir which should be built with CMake etc since there currently is no top level CMakeLists.txt that does the right thing.
I didn't want to delay the easyblock PR to make this happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make the CMAKE_OPTIONS set in easyblock, and actually I tried that before. I did not know how to add a local option for a particular easyconfigs, but I will do it.
requires:
make installeasybuild-easyblocks#3004