change LAMMPS easyblock to check for kokkos_arch before generic optarch

[Thyre]

(created using eb --new-pr)

Follow-up to #3943.

---

Instead of allowing to specify kokkos_arch when we build with a generic optarch, causing ARMV80 to be used, move the precedence of kokkos_arch to be considered first. The workaround implemented in #3943 only applied for aarch64 and included code duplication for the else branch coming directly afterwards.

With this, one can also use kokkos_arch on x86 platforms to work around potential issues, even when working with a generic optarch.

[ocaisa]

LGTM

[ocaisa]

@boegelbot please test @ jsc-zen3 EB_ARGS= LAMMPS-2Aug2023_update2-foss-2023a-kokkos.eb

[boegelbot]

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3945 EB_ARGS="" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3945 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

• exit code: 0
• output:

Submitted batch job 8059

Test results coming soon (I hope)...

- notification for comment with ID 3334314169 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

[Thyre]

boegelbot please test @ jsc-zen3 EB_ARGS= LAMMPS-2Aug2023_update2-foss-2023a-kokkos.eb

Hm, that build silently failed on jsc-zen3. I'll try manually.
Edit: Maybe because of the space between EB_ARGS and the EasyConfig?

[ocaisa]

@boegelbot please test @ jsc-zen3 EB_ARGS="LAMMPS-2Aug2023_update2-foss-2023a-kokkos.eb"

[boegelbot]

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3945 EB_ARGS="LAMMPS-2Aug2023_update2-foss-2023a-kokkos.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3945 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

• exit code: 0
• output:

Submitted batch job 8063

Test results coming soon (I hope)...

- notification for comment with ID 3337046268 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

[ocaisa]

Edit: Maybe because of the space between EB_ARGS and the EasyConfig?

Most likely, I copy-pasted a search result where it turns out that GitHub cleans out the quotation marks

[boegelbot]

Test report by @boegelbot

Overview of tested easyconfigs (in order)

• SUCCESS LAMMPS-2Aug2023_update2-foss-2023a-kokkos.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/ab8d57f28962e15a9e518bfd22b626b4 for a full test report.