enhance LAMMPS easyblock to make it possible to overide kokkos_arch for GENERIC ARM target
#3943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: laraPPr <[email protected]>
ocaisa
approved these changes
Sep 25, 2025
Member
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
Verified via EESSI/software-layer-scripts#88 (comment)
Thyre
reviewed
Sep 25, 2025
Comment on lines
+279
to
+288
| if kokkos_arch: | ||
| # If someone is trying a manual override for this case, let them | ||
| if kokkos_arch not in KOKKOS_CPU_ARCH_LIST: | ||
| warning_msg = "Specified CPU ARCH (%s) " % kokkos_arch | ||
| warning_msg += "was not found in listed options [%s]." % KOKKOS_CPU_ARCH_LIST | ||
| warning_msg += "Still might work though." | ||
| print_warning(warning_msg) | ||
| processor_arch = kokkos_arch | ||
| else: | ||
| processor_arch = 'ARMV80' |
Collaborator
There was a problem hiding this comment.
I understand the idea, but this looks weird nonetheless.
This will still print a warning because kokkos_arch is set, even though it is not ignored but will be used. It's also confusing that this only applies for aarch64, even though one might want to use the same approach for x86 when the generic optarch is set.
Instead, we should probably check kokkos_arch first and the optarch if kokkos_arch is not set.
This would allow EESSI to use the overwrite, and increase flexibility in general.
Member
Member
There was a problem hiding this comment.
Ah, already done in:
boegel
changed the title
kokkos_arch for GENERIC ARM target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some context for this change: there is a problem with CUDA<13.1 for Arm architectures which try to leverage NEON instructions. The workaround in EESSI/software-layer-scripts#87 is to override the architecture detection so these are not included. This change allows you to do that even for the generic case.