Skip to content

enhance Python easyblock to create non-versioned symlink for python-config + check for bin/python and bin/python-config in sanity check #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 3 commits into from
Mar 15, 2023
Merged

enhance Python easyblock to create non-versioned symlink for python-config + check for bin/python and bin/python-config in sanity check #2904

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42d5b98
Create non-versioned symlink for python-config
VRehnberg Mar 14, 2023
f564900
Add extra sanity checks
VRehnberg Mar 14, 2023
7b7ad98
Move python-config --help sanity check
VRehnberg Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions easybuild/easyblocks/p/python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,10 +444,13 @@ def install_step(self):

super(EB_Python, self).install_step()

# Create non-versioned, relative symlinks for python and pip
# Create non-versioned, relative symlinks for python, python-config and pip
python_binary_path = os.path.join(self.installdir, 'bin', 'python')
if not os.path.isfile(python_binary_path):
symlink('python' + self.pyshortver, python_binary_path, use_abspath_source=False)
python_config_binary_path = os.path.join(self.installdir, 'bin', 'python-config')
if not os.path.isfile(python_config_binary_path):
symlink('python' + self.pyshortver + '-config', python_config_binary_path, use_abspath_source=False)
if self.install_pip:
pip_binary_path = os.path.join(self.installdir, 'bin', 'pip')
if not os.path.isfile(pip_binary_path):
Expand Down Expand Up @@ -534,7 +537,13 @@ def sanity_check_step(self):

pyver = 'python' + self.pyshortver
custom_paths = {
'files': [os.path.join('bin', pyver), os.path.join('lib', 'lib' + pyver + abiflags + '.' + shlib_ext)],
'files': [
os.path.join('bin', pyver),
os.path.join('bin', 'python'),
os.path.join('bin', pyver + '-config'),
os.path.join('bin', 'python-config'),
os.path.join('lib', 'lib' + pyver + abiflags + '.' + shlib_ext),
],
'dirs': [os.path.join('include', pyver + abiflags), os.path.join('lib', pyver, 'lib-dynload')],
}

Expand All @@ -543,6 +552,7 @@ def sanity_check_step(self):

custom_commands = [
"python --version",
"python-config --help", # make sure that symlink was created correctly
"python -c 'import _ctypes'", # make sure that foreign function interface (libffi) works
"python -c 'import _ssl'", # make sure SSL support is enabled one way or another
"python -c 'import readline'", # make sure readline support was built correctly
Expand Down