Skip to content

Conversation

@VRehnberg
Copy link
Contributor

Occasionally there are configure scripts that assume existance of python-config. But existing easybuild installations for Python3 will only create python3-config. This is a remedy to that problem. Previously discussed here:
https://easybuild.slack.com/archives/C34UA1HT7/p1678728109206609?thread_ts=1678722749.081689&cid=C34UA1HT7

@boegel boegel added this to the next release (4.7.1) milestone Mar 14, 2023
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add python-config --help as sanity check command (so people can easily see that their Python installation is missing the symlink)?

Maybe also add both bin/python and bin/python-config in files in sanity_check_paths (via custom_paths in sanity_check_step) while you're at it...

@VRehnberg
Copy link
Contributor Author

VRehnberg commented Mar 14, 2023

Let's also add python-config --help as sanity check command (so people can easily see that their Python installation is missing the symlink)?

Maybe also add both bin/python and bin/python-config in files in sanity_check_paths (via custom_paths in sanity_check_step) while you're at it...

I added versioned python-config in path sanity check as well to make it consistent with sanity checks for python. Let me know if you think it's unnecessary and I'll remove it.

@boegel boegel changed the title Create non-versioned symlink for python-config enhance Python easyblock to create non-versioned symlink for python-config + check for bin/python and bin/python-config in sanity check Mar 14, 2023
@VRehnberg VRehnberg requested a review from boegel March 14, 2023 13:06
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Mar 15, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Python-2.7.16-GCCcore-8.3.0.eb
  • SUCCESS Python-2.7.18-GCCcore-11.2.0-bare.eb
  • SUCCESS Python-3.7.4-GCCcore-8.3.0.eb
  • SUCCESS Python-3.9.6-GCCcore-11.2.0.eb
  • SUCCESS Python-3.10.8-GCCcore-12.2.0.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3170.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/8a3963c2d9d64df3ab0fa83b2b6aa9b2 for a full test report.

@boegel boegel merged commit aa4f324 into easybuilders:develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants