Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Mar 25, 2019

  • stop additional import check, which is already done by default for all Python packages (based on software name)
  • stop checking for specific lib/python*/site-packages, rely on det_pylibdir() instead to ensure correct path is checked depending on active python command
    • some minor cleanup

Especially not checking for self.pyblidr is important w.r.t. supporting multi-Python installations of (bundles that include) numpy or scipy (cfr. easybuilders/easybuild-easyconfigs#7921 and easybuilders/easybuild-easyconfigs#7922).

Copy link
Member

@damianam damianam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants