Skip to content

tweak PythonPackage & PythonBundle to update $EBPYTHONPREFIXES rather than $PYTHONPATH for multi-Python installations + make sanity_check_step aware of multi_deps #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
damianam merged 3 commits into from
Mar 29, 2019
Merged

tweak PythonPackage & PythonBundle to update $EBPYTHONPREFIXES rather than $PYTHONPATH for multi-Python installations + make sanity_check_step aware of multi_deps #1664

damianam merged 3 commits into from
Mar 29, 2019

Conversation

@boegel
Copy link
Member

@boegel boegel commented Mar 24, 2019 •
edited
Loading

follow-up for #1657, requires easybuilders/easybuild-framework#2813 to be merged first

cc @bartoldeman

boegel added 2 commits March 24, 2019 11:11
@boegel
tweak PythonPackage & PythonBundle to update $EBPYTHONPREFIXES rather…
c164753 
… than $PYTHONPATH for multi-Python installations + make sanity_check_step aware of multi_deps
@boegel
also inject lib/python%(pyshortver)s/site-packages as default sanity_…
0c7ac0b 
…check_paths dir in PythonPackage easyblock
@boegel boegel added this to the next release (3.8.2) milestone Mar 24, 2019
@boegel boegel requested a review from damianam March 24, 2019 10:24
@boegel boegel mentioned this pull request Mar 24, 2019
Merged
This was referenced Mar 25, 2019
Merged
Merged
damianam
damianam reviewed Mar 26, 2019
View reviewed changes
@easybuilders easybuilders deleted a comment from boegelbot Mar 26, 2019
bartoldeman
bartoldeman approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

damianam
damianam approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@damianam damianam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@easybuilders easybuilders deleted a comment from boegelbot Mar 29, 2019
@damianam damianam merged commit e8ce7d3 into easybuilders:develop Mar 29, 2019
@boegel boegel deleted the multi_python branch March 29, 2019 11:48
@boegel boegel mentioned this pull request Apr 9, 2019
Merged
@boegel boegel mentioned this pull request Apr 29, 2019
Merged
@boegel boegel mentioned this pull request Sep 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

@damianam damianam damianam approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @bartoldeman @damianam