Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 29, 2024

Description

This PR adds an extra check before checking checking the target properties. This fix should solve the issue linked in the task.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • N/A: Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5435 done by [Mergify](https://mergify.com).

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit dbb87b7)
@mergify mergify bot mentioned this pull request Nov 29, 2024
9 tasks
@MiguelCompany MiguelCompany added this to the v2.14.5 milestone Nov 29, 2024
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Nov 29, 2024
@MiguelCompany MiguelCompany self-requested a review November 29, 2024 10:53
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 29, 2024
@MiguelCompany MiguelCompany merged commit ead5329 into 2.14.x Dec 11, 2024
15 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.14.x/pr-5435 branch December 11, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants