Skip to content

[22341] Fix cmake generator evaluation #5435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MiguelCompany merged 1 commit into from
Nov 29, 2024
Merged

[22341] Fix cmake generator evaluation #5435

MiguelCompany merged 1 commit into from
Nov 29, 2024

Conversation

@Mario-DL
Copy link
Contributor

@Mario-DL Mario-DL commented Nov 28, 2024 •
edited by MiguelCompany
Loading

Description

This PR adds an extra check before checking checking the target properties. This fix should solve the issue linked in the task.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • N/A: Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added the no-test Skip CI tests if PR marked with this label label Nov 28, 2024
@Mario-DL Mario-DL added this to the v3.2.0 milestone Nov 28, 2024
@Mario-DL Mario-DL linked an issue Nov 28, 2024 that may be closed by this pull request
[22340] Error evaluating generator expression #5283
Closed
1 task
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima November 28, 2024 08:18
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 28, 2024
@MiguelCompany
Copy link
Member

MiguelCompany commented Nov 29, 2024

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit dbb87b7 into master Nov 29, 2024
14 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/22341 branch November 29, 2024 10:47
mergify bot pushed a commit that referenced this pull request Nov 29, 2024
@Mario-DL @mergify
Fix cmake generator evaluation (#5435)
18c9792 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit dbb87b7)
@mergify mergify bot mentioned this pull request Nov 29, 2024
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Nov 29, 2024
@Mario-DL @mergify
Fix cmake generator evaluation (#5435)
5055b49 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit dbb87b7)
@mergify mergify bot mentioned this pull request Nov 29, 2024
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Nov 29, 2024
@Mario-DL @mergify
Fix cmake generator evaluation (#5435)
92d8e49 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit dbb87b7)
@mergify mergify bot mentioned this pull request Nov 29, 2024
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Nov 29, 2024
@Mario-DL @mergify
Fix cmake generator evaluation (#5435)
cdc4eaa 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit dbb87b7)

# Conflicts:
#	src/cpp/CMakeLists.txt
@mergify mergify bot mentioned this pull request Nov 29, 2024
Closed
9 tasks
rsanchez15 pushed a commit that referenced this pull request Dec 9, 2024
@mergify @Mario-DL
Fix cmake generator evaluation (#5435) (#5452)
b0e1c69 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit dbb87b7)

Co-authored-by: Mario Domínguez López <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Dec 11, 2024
@mergify @Mario-DL
Fix cmake generator evaluation (#5435) (#5451)
991e265 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit dbb87b7)

Co-authored-by: Mario Domínguez López <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Dec 11, 2024
@mergify @Mario-DL
Fix cmake generator evaluation (#5435) (#5453)
ead5329 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit dbb87b7)

Co-authored-by: Mario Domínguez López <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label

Projects

None yet

Milestone

v3.2.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

[22340] Error evaluating generator expression

3 participants

@Mario-DL @MiguelCompany