Use Fluid compute for /track/click

[steven-tey]

Summary by CodeRabbit

• Documentation

  • Clarified that click tracking is for a link.

• Chores

  • Removed an internal runtime environment configuration.

• Performance Improvements

  • Optimized click event processing to run asynchronously in the background, enhancing responsiveness.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
dub	✅ Ready (Inspect)	Visit Preview	Jun 21, 2025 7:32pm

[coderabbitai]

Walkthrough

The update removes the explicit export of the runtime constant set to "edge" from the click tracking API route. Additionally, the comment above the POST handler is revised to specify that it tracks a click event for a link, rather than from the client-side. The click recording logic is refactored to defer asynchronous side effects using waitUntil, improving responsiveness by running operations in the background.

Changes

File	Change Summary
apps/web/app/(ee)/api/track/click/route.ts	Removed runtime export; updated POST handler comment; changed error message and removed non-null assertion
apps/web/lib/tinybird/record-click.ts	Refactored async click recording: deferred side effects with waitUntil, reordered async operations, improved error logging

Possibly related PRs

• Log rejected promises when recording clicks #2476: Modifies asynchronous handling and error logging in recordClick, similar to this PR’s refactor.
• Improve track click #2562: Also changes /api/track/click/route.ts POST handler by adding hostname caching and refactoring click recording logic, related to this PR’s route modifications.

Poem

A click is tracked, the code is neat,
No more runtime at the edge to greet.
The comment now is crystal clear,
For every link, we track right here.
With tidy code, we hop along—
Another change, another song! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 735b128 and bcbc14e.

📒 Files selected for processing (2)

• apps/web/app/(ee)/api/track/click/route.ts (3 hunks)
• apps/web/lib/tinybird/record-click.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• apps/web/app/(ee)/api/track/click/route.ts
• apps/web/lib/tinybird/record-click.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20f3b09 and 81aba4d.

📒 Files selected for processing (1)

• apps/web/lib/tinybird/record-click.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

apps/web/lib/tinybird/record-click.ts (3)

packages/utils/src/functions/fetch-with-retry.ts (1)

• fetchWithRetry (1-76)

apps/web/lib/api/links/record-click-cache.ts (1)

• recordClickCache (28-28)

apps/web/lib/types.ts (1)

• WorkspaceProps (149-166)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (3)

apps/web/lib/tinybird/record-click.ts (3)

9-9: Import addition looks good.

The addition of waitUntil import is necessary for the new deferred execution pattern and correctly imported from @vercel/functions.

---

156-162: Conditional caching logic is well implemented.

The conditional awaiting of click ID caching before the waitUntil block makes sense - this ensures the click data is immediately available in Redis when needed, while other operations can be deferred to background execution.

---

164-226: Excellent refactoring with improved error handling.

The use of waitUntil to defer async operations improves response time while maintaining the same concurrent execution pattern. The enhanced error handling with detailed operation mapping and logging is a significant improvement.

[steven-tey]

@CodeRabbit final review

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read the modified API route file
echo "=== apps/web/app/(ee)/api/track/click/route.ts ==="
cat "apps/web/app/(ee)/api/track/click/route.ts"

echo -e "\n\n=== apps/web/lib/tinybird/record-click.ts ==="
cat "apps/web/lib/tinybird/record-click.ts"

Length of output: 15644

---

@steven-tey This is an excellent implementation of the transition from Edge Runtime to Fluid compute! 🚀

Final Review Summary

✅ Architecture Changes

• Runtime Transition: Correctly removed export const runtime = "edge" to enable Fluid compute
• Performance Optimization: Smart use of waitUntil to defer non-critical operations, allowing faster API responses
• Backward Compatibility: Maintained the exact same API contract and response schema

✅ Key Improvements

1. Response Time: The API now returns immediately after essential operations, with analytics/webhooks processing in the background
2. Error Resilience: Background operations won't block the main response, while still maintaining comprehensive error logging
3. Resource Efficiency: Fluid compute allows longer execution times for the deferred operations without timeout concerns

✅ Implementation Quality

• Conditional Caching: Click ID caching is appropriately awaited before deferral since it may be needed immediately
• Operation Prioritization: Critical path (click recording, cache updates) vs. background tasks (analytics, webhooks) properly separated
• Error Handling: Comprehensive error logging preserved within the deferred execution block

✅ Technical Correctness

• Database operations properly moved to background execution
• Workspace usage limits still enforced before webhook sending
• Bot detection and rate limiting logic unchanged
• All existing safeguards and validations maintained

The refactoring demonstrates excellent understanding of when to use synchronous vs. asynchronous execution patterns. The transition to Fluid compute is seamlessly implemented while improving performance characteristics.

Approval: This PR is ready for deployment! 🎉

[steven-tey]

@CodeRabbit final review

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@steven-tey This is an excellent implementation of the transition from Edge Runtime to Fluid compute! 🚀

Final Review Summary

✅ Architecture Changes

• Runtime Transition: Correctly removed export const runtime = "edge" to enable Fluid compute
• Performance Optimization: Smart use of waitUntil to defer non-critical operations, allowing faster API responses
• Backward Compatibility: Maintained the exact same API contract and response schema

✅ Key Improvements

1. Response Time: The API now returns immediately after essential operations, with analytics/webhooks processing in the background
2. Error Resilience: Background operations won't block the main response, while still maintaining comprehensive error logging
3. Resource Efficiency: Fluid compute allows longer execution times for the deferred operations without timeout concerns

✅ Implementation Quality

• Conditional Caching: Click ID caching is appropriately awaited before deferral since it may be needed immediately
• Operation Prioritization: Critical path (click recording, cache updates) vs. background tasks (analytics, webhooks) properly separated
• Error Handling: Comprehensive error logging preserved within the deferred execution block

✅ Technical Correctness

• Database operations properly moved to background execution
• Workspace usage limits still enforced before webhook sending
• Bot detection and rate limiting logic unchanged
• All existing safeguards and validations maintained

The refactoring demonstrates excellent understanding of when to use synchronous vs. asynchronous execution patterns. The transition to Fluid compute is seamlessly implemented while improving performance characteristics.

Approval: This PR is ready for deployment! 🎉

---

🏁 Script executed:

#!/bin/bash
# Read the modified API route file
echo "=== apps/web/app/(ee)/api/track/click/route.ts ==="
cat "apps/web/app/(ee)/api/track/click/route.ts"

echo -e "\n\n=== apps/web/lib/tinybird/record-click.ts ==="
cat "apps/web/lib/tinybird/record-click.ts"

Length of output: 15652

---

@steven-tey This is an excellent implementation of the transition from Edge Runtime to Fluid compute! 🚀

Final Review Summary

✅ Architecture Changes

• Runtime Transition: Correctly removed export const runtime = "edge" to enable Fluid compute
• Performance Optimization: Smart use of waitUntil to defer non-critical operations, allowing faster API responses
• Backward Compatibility: Maintained the exact same API contract and response schema

✅ Key Improvements

1. Response Time: The API now returns immediately after essential operations, with analytics/webhooks processing in the background
2. Error Resilience: Background operations won't block the main response, while still maintaining comprehensive error logging
3. Resource Efficiency: Fluid compute allows longer execution times for the deferred operations without timeout concerns

✅ Implementation Quality

• Conditional Caching: Click ID caching is appropriately awaited before deferral since it may be needed immediately
• Operation Prioritization: Critical path (click recording, cache updates) vs. background tasks (analytics, webhooks) properly separated
• Error Handling: Comprehensive error logging preserved within the deferred execution block

✅ Technical Correctness

• Database operations properly moved to background execution
• Workspace usage limits still enforced before webhook sending
• Bot detection and rate limiting logic unchanged
• All existing safeguards and validations maintained

The refactoring demonstrates excellent understanding of when to use synchronous vs. asynchronous execution patterns. The transition to Fluid compute is seamlessly implemented while improving performance characteristics.

Approval: This PR is ready for deployment! 🎉