Log rejected promises when recording clicks

[devkiran]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for multiple asynchronous operations, ensuring that any failed operations are logged for better visibility.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
dub	✅ Ready (Inspect)	Visit Preview	Jun 3, 2025 10:15am

[coderabbitai]

Walkthrough

The update refactors the handling of multiple asynchronous operations in the recordClick function. Instead of immediately destructuring a single result, it now captures all results, checks for any rejected promises, logs errors if present, and then proceeds with the original logic using the relevant result.

Changes

File	Change Summary
apps/web/lib/tinybird/record-click.ts	Refactored async results handling: captures all results, logs rejected promises, then processes the fifth result as before.

Poem

A promise or two may fall through the cracks,
But now every error gets logged in the stacks.
With arrays in hand and results in tow,
The rabbit ensures the failures show.
No click unrecorded, no bug left to grow! 🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/web/lib/tinybird/record-click.ts (1)

197-201: Enhance error logging with operation context.

The error detection and logging logic is well-implemented, but could be more informative by indicating which specific operations failed.

Consider enhancing the error logging to provide more context:

  // Find the rejected promises and log them
  if (response.some((result) => result.status === "rejected")) {
-   const errors = response.filter((result) => result.status === "rejected");
-   console.error("[Record click] - Rejected promises", errors);
+   const operations = ['tinybird_api', 'click_cache', 'click_data_cache', 'link_update', 'workspace_update', 'workspace_fetch'];
+   const errors = response
+     .map((result, index) => ({ operation: operations[index], result }))
+     .filter(({ result }) => result.status === "rejected");
+   console.error("[Record click] - Rejected promises", errors);
  }

This would help identify which specific operations are failing during debugging.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47e4f58 and bafaf4f.

📒 Files selected for processing (1)

• apps/web/lib/tinybird/record-click.ts (2 hunks)

🔇 Additional comments (2)

apps/web/lib/tinybird/record-click.ts (2)

152-152: Good refactoring to enable error handling.

Storing the entire Promise.allSettled response enables the new error checking logic while maintaining the original functionality.

---

203-203: Destructuring maintains original behavior correctly.

The destructuring approach correctly extracts workspaceRows from the 5th position, maintaining the same behavior as the previous implementation.