Skip to content

Fix Rector job on PR to main repository #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driftingly merged 2 commits into from
Feb 7, 2023
Merged

Fix Rector job on PR to main repository #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54731e3
Run Rector only for core contributors (which make branches on the mai…
rene-bos Feb 7, 2023
3f57062
Create Rector failure to test this
rene-bos Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/code_analysis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ jobs:
uses: rectorphp/reusable-workflows/.github/workflows/code_analysis.yaml@main

rector:
# run only on main repository, not on the forks without access
if: github.repository == 'driftingly/rector-laravel'
# run only on PR's from branches on main repository (from core contributors), not on the forks or PR's from forks.
if: github.event.pull_request.head.repo.full_name == github.repository

# see https://github.com/rectorphp/reusable-workflows
uses: rectorphp/reusable-workflows/.github/workflows/rector.yaml@main
4 changes: 2 additions & 2 deletions src/NodeAnalyzer/LumenRouteRegisteringMethodAnalyzer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ public function __construct(
) {
}

public function isLumenRoutingClass(MethodCall $methodCall): bool
public function isLumenRoutingClass(MethodCall $node): bool
{
return $this->nodeTypeResolver->isObjectType($methodCall->var, new ObjectType('Laravel\Lumen\Routing\Router'));
return $this->nodeTypeResolver->isObjectType($node->var, new ObjectType('Laravel\Lumen\Routing\Router'));
}

public function isRoutesRegisterGroup(Identifier|Expr $name): bool
Expand Down