Skip to content

Conversation

@rene-bos
Copy link
Contributor

@rene-bos rene-bos commented Feb 7, 2023

Run only on PR's from branches on main repository (from core contributors), not on the forks or PR's from forks.

@driftingly
Copy link
Owner

I might have merged this too early. Sorry!

@rene-bos
Copy link
Contributor Author

rene-bos commented Feb 7, 2023

No problem! It should have created it as draft if I did not wanted it to get merged. Its fine to be merged I think. If TomasVotruba agrees to move the check to rector.yaml we can just remove the if-statement.

For now we can keep the change here, as it will avoid errors like we had on #82.

@rene-bos rene-bos deleted the fix-rector-on-pr-to-upstream branch February 7, 2023 17:19
@driftingly
Copy link
Owner

Should we revert 3f57062

@rene-bos
Copy link
Contributor Author

rene-bos commented Feb 7, 2023

Yeah that's a good one. When we don't fix it it will pop up in a totally unrelated pull request some time 😉 Because of some strange hickup the change has already been committed to #82 ([ci-review] Rector Rectify).

Do you have time to check #82 and maybe create a release afterwards? At my company (Visma) we would love to have that change 😄. Avoids pinning to our fork and the associated maintenance of it. Sorry for making your day busy with all that PR's 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants